On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
> Hi,
>
> I've uploaded a patch for review:
> https://review.openstack.org/#/c/531674/
>
> This is the first time I'm submitting a patch on openstack. I'd like
> to add code reviewers on this patch. I'd appreciate if you could point
> me to any guidelines on how to pick reviewers for a given project
> (os-vif library in this case).
In general, there's no need to add core reviewers to a review. Each of
us have their own dashboards or watch projects that we review and review
as time permits.
Since your change is failing the testsuite: Please fix tests first!
os-vif is part of nova, so if you want to discuss about it, best to join
the #openstack-nova freenode IRC channel,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
