On 2018-01-09 07:00, Sriharsha Basavapatna wrote: > Hi, > > I've uploaded a patch for review: > https://review.openstack.org/#/c/531674/ > > This is the first time I'm submitting a patch on openstack. I'd like
Welcome to OpenStack, Harsha. Please read https://docs.openstack.org/infra/manual/developers.html if you haven't. I see that your change fails the basic tests, you can run these locally as follows to check that your fixes will pass: tox -e pep8 tox -e py27 Andreas > to add code reviewers on this patch. I'd appreciate if you could point > me to any guidelines on how to pick reviewers for a given project > (os-vif library in this case). > > Thanks, > -Harsha > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev