On Mon, 2018-01-15 at 17:21 +0000, Mooney, Sean K wrote: > > -----Original Message----- > > From: [email protected] [mailto:[email protected]] > > Sent: Monday, January 15, 2018 4:46 PM > > To: [email protected] > > Subject: [openstack-dev] [kuryr][os-vif][nova] os-vif 1.8.0 breaks > > kuryr-kubernetes > > > > Hi, > > > > os-vif commit [1] introduced a non-backward compatible change to the > > Subnet object - removal of ips field. Turns out kuryr-kubernetes were > > depending on that e.g. here [1] and we're now broken with os-vif 1.8.0. > > > > kuryr-kubernetes is saving the VIF objects into the K8s resources > > annotations, so to keep backwards compatibility we need > > VIFBase.obj_make_compatible able to backport the data back into the > > Subnet object. Or be able to load the older data to the newer object. > > Anyone have an advice how we should proceed with that issue? > > [Mooney, Sean K] I belive obj_make_compatible methods were in the original > Patch but they were removed as we did not know of any user of this field. > The IPs field in the subnet object Was a legacy hold over from when the > object was ported from nova-networks. > it is never used by nova when calling os-vif today hence the > change to align the data structure more closely with neutrons > where the fixed ips are an attribute of the port. > The change was made to to ensure no future users of os-vif consumed > the fixed ips from the subnet object but I guess kuryr-kubernetes had already > done so. > > Ideally we would migrate kuryr-kubernetes to consume fixed_ips form The vif > object instead of the subnet > but if we can introduce a patch to os-vif to provide backwards compatibly > before the non-client lib freeze on thrusday we can include that in queens.
I prefer Jay's proposed solution of simply doing a revert of the patch, though this would work as well, at least as short-term remediation. > > > > It would also be nice to setup a kuryr-kubernetes gate on the os-vif > > repo. If there are no objections to that I'd volunteer to submit a > > commit that adds it. > > [Mooney, Sean K] I would be happy to see gate form all consumer of os-vif so > go for it. Will do! > Related to this https://review.openstack.org/#/c/509107/4 is currently > abandoned but I would > Also like revivew this change in Rocky. Neutron has supported multiple dhcp > servers for > some time, Nova-networks only supported one hench why the dhcp_server field > is currently singular. > Will this effect kuryr-kubernetes? > Are ye currently working around this issue in some other way? Looks like kuryr-kubernetes doesn't depend on dhcp_server field, though I believe we should work out a way of doing such changes that's safe for everyone. Making guesses on projects depending on certain fields is dangerous. __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
