On Thu, Apr 26, 2018 at 09:27:31AM -0500, Sean McGinnis wrote: > On Wed, Apr 25, 2018 at 04:54:46PM -0400, Doug Hellmann wrote: > > It's time to talk about the next steps in our migration from python > > 2 to python 3. > > > > [...] > > > > 2. Change (or duplicate) all functional test jobs to run under > > python 3. > > As a test I ran Cinder functional and unit test jobs on bionic using 3.6. All > went well. > > That made me realize something though - right now we have jobs that explicitly > say py35, both for unit tests and functional tests. But I realized setting up > these test jobs that it works to just specify "basepython = python3" or run > unit tests with "tox -e py3". Then with that, it just depends on whether the > job runs on xenial or bionic as to whether the job is run with py35 or py36. > > It is less explicit, so I see some downside to that, but would it make sense > to > change jobs to drop the minor version to make it more flexible and easy to > make > these transitions? > I still think using tox-py35 / tox-py36 makes sense, as those jobs are already setup to use the specific nodeset of ubuntu-xenial or ubuntu-bionic. If we did move to just tox-py3, it would actually result if more code projects would need to add to their .zuul.yaml files:
-project: check: jobs: - tox-py35 -project: check: jobs: - tox-py3: nodeset: ubuntu-xenial This maybe okay, will allow others to comment, but the main reason I am not a fan, is we can no longer infer the nodeset by looking at the job name. tox-py3 could be xenial or bionic. Paul __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev