On 07/12/2018 04:29 PM, Eric Fried wrote:
Here it is for nova.

https://review.openstack.org/#/c/582392/

also don't love that immediately bumping the lower bound for tox is
going to be kind of disruptive to a lot of people.

By "kind of disruptive," do you mean:

  $ tox -e blah
  ERROR: MinVersionError: tox version is 1.6, required is at least 3.1.1
  $ sudo pip install --upgrade tox
  <types password>
  $ tox -e blah
  <world continues turning>

Repeat for every developer on every project that gets updated. And if you installed tox from a distro package then it might not be that simple since pip installing over distro packages can get weird.

No, it's not a huge deal, but then neither is the repetition in tox.ini so I'd just as soon leave it be for now. But I'm not going to -1 any patches either.


?

Thanks,
efried

On 07/09/2018 03:58 PM, Doug Hellmann wrote:
Excerpts from Ben Nemec's message of 2018-07-09 15:42:02 -0500:

On 07/09/2018 11:16 AM, Eric Fried wrote:
Doug-

     How long til we can start relying on the new behavior in the gate?  I
gots me some basepython to purge...

I want to point out that most projects require a rather old version of
tox, so chances are most people are not staying up to date with the very
latest version.  I don't love the repetition in tox.ini right now, but I
also don't love that immediately bumping the lower bound for tox is
going to be kind of disruptive to a lot of people.

1: http://codesearch.openstack.org/?q=minversion&i=nope&files=tox.ini&repos=

Good point. Any patches to clean up the repetition should probably
go ahead and update that minimum version setting, too.

Doug

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to