I’d rather us explicitly skip the tests if the module is not available.

mark

On Jan 13, 2014, at 3:39 PM, Collins, Sean <[email protected]> 
wrote:

> On Wed, Jan 01, 2014 at 07:56:22PM -0800, Clark Boylan wrote:
>> It looks like the problem is that there is a dependency on pyudev
>> which only works properly on Linux. The neutron setup_hook does
>> properly install pyudev on Linux (explains why the tests run in the
>> gate), but would not work properly on windows or OS X. I assume folks
>> are trying to run the tests on not Linux? Neutron may want to do
>> something similar to what Nova does when libvirt is not importable,
>> https://git.openstack.org/cgit/openstack/nova/tree/nova/tests/virt/libvirt/test_libvirt.py#n77
>> and use a fake in order to get the tests to run properly anyways.
> 
> Thanks for pointing this out - I've begun work on doing this, and that
> link was very helpful for figuring out what would need to be done.
> 
> -- 
> Sean M. Collins
> _______________________________________________
> OpenStack-dev mailing list
> [email protected]
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


_______________________________________________
OpenStack-dev mailing list
[email protected]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to