I agree, the gantt tree during the interim will be tightly coupled with the nova tree, any changes to those internal nova APIs will have to be reflected back into the gantt tree. Ultimately we want to completely decouple gantt from nova but that is a harder problem than just moving the scheduler specific code into a separate tree.
When I said `cut the cord from nova it'll be easy' I was referring to identifying what imports need to be addressed. Actually fixing gantt to not use that nova code will certainly be a big job. -- Don Dugger "Censeo Toto nos in Kansa esse decisse." - D. Gale Ph: 303/443-3786 From: Joe Gordon [mailto:[email protected]] Sent: Wednesday, January 22, 2014 2:31 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [gantt] How to include nova modules in unit tests On Tue, Jan 21, 2014 at 7:35 PM, Dugger, Donald D <[email protected]<mailto:[email protected]>> wrote: Well, the first goal is to get the scheduler code into a separate tree, even though that code is still utilizing common code from nova. Right now just about every scheduler file includes some nova modules. Ultimately yes, we want to remove the depency on nova but that is a future effort and would create way too many changes for the immediate future. The nova code you are trying to use isn't a public API and can change at any time. Before considering using gantt we would have to fully remove any nova imports in gantt. When we want to cut the cord from nova it'll be easy, just remove that line from the `test-requirements.txt' file and we'll be forced to replace all of the nova code. I'm not sure it will actually be that easy. -- Don Dugger "Censeo Toto nos in Kansa esse decisse." - D. Gale Ph: 303/443-3786<tel:303%2F443-3786> -----Original Message----- From: Robert Collins [mailto:[email protected]<mailto:[email protected]>] Sent: Tuesday, January 21, 2014 5:16 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [gantt] How to include nova modules in unit tests On 22 January 2014 11:57, Dugger, Donald D <[email protected]<mailto:[email protected]>> wrote: > I almost have the unit tests for gantt working except for one problem > - is there a way to have the test infrastructure allow the gantt tree > to import objects from the nova tree. > > > > The problem is that we want to break out just the scheduler code into > the gantt tree without duplicating all of nova. The current scheduler > has many imports of nova objects, which is not a problem except for the unit > tests. > The unit tests run in an environment that doesn't include the nova > tree so all of those imports wind up failing. The goal though is to have an independent system; perhaps marking all the tests that still depend on tendrils of nova 'skipped' and then work on burning down the skips to 0 is a better approach than making it easy to have such dependencies? -Rob -- Robert Collins <[email protected]<mailto:[email protected]>> Distinguished Technologist HP Converged Cloud _______________________________________________ OpenStack-dev mailing list [email protected]<mailto:[email protected]> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list [email protected]<mailto:[email protected]> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
