Well, git knows all the files in-tree, right? Or am I missing something here?
if-has-bash-hashbang-and-is-versioned-then-bashate-it? -Rob On 3 September 2014 13:26, Ian Wienand <iwien...@redhat.com> wrote: > On 09/02/2014 10:13 PM, Sean Dague wrote: >> >> One of the things that could make it better is to add file extensions to >> all shell files in devstack. This would also solve the issue of gerrit >> not syntax highlighting most of the files. If people are up for that, >> I'll propose a rename patch to get us there. Then dumping the special >> bashate discover bits is simple. > > > I feel like adding .sh to bash to-be-sourced-only (library) files is > probably a less common idiom. It's just feeling, I don't think it's > any sort of rule. > > So my first preference is for bashate to just punt the whole thing and > only work on a list of files. We can then discuss how best to match > things in devstack so we don't add files but miss checking them. > > -i > > > _______________________________________________ > OpenStack-dev mailing list > OpenStackfirstname.lastname@example.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Robert Collins <rbtcoll...@hp.com> Distinguished Technologist HP Converged Cloud _______________________________________________ OpenStack-dev mailing list OpenStackemail@example.com http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev