On Sep 3, 2014, at 12:20 PM, Dolph Mathews <dolph.math...@gmail.com> wrote:

> 
> On Wed, Sep 3, 2014 at 8:25 AM, Sean Dague <s...@dague.net> wrote:
> On 09/03/2014 09:03 AM, Daniel P. Berrange wrote:
> > On Wed, Sep 03, 2014 at 08:37:17AM -0400, Sean Dague wrote:
> >> I'm not sure why people keep showing up with "sort requirements" patches
> >> like - https://review.openstack.org/#/c/76817/6, however, they do.
> >>
> >> All of these need to be -2ed with predjudice.
> >>
> >> requirements.txt is not a declarative interface. The order is important
> >> as pip processes it in the order it is. Changing the order has impacts
> >> on the overall integration which can cause wedges later.
> >
> > Can  requirements.txt contain comment lines ?  If so, it would be
> > worth adding
> >
> >    # The ordering of modules in this file is important
> >    # Do not attempt to re-sort the lines
> >
> > Because 6 months hence people will have probably forgotten about
> > this mail, or if they're new contributors, never know it existed.
> 
> The point is that core review team members should know. In this case at
> least one glance core +2ed this change.
> 
> Regular contributors can be educated by core team members.
> 
> Regardless, tribal knowledge should be documented, and doing so in 
> requirements files is probably the best place for that.

+1

Write-it-down-ly,
Doug

>  
> 
>         -Sean
> 
> --
> Sean Dague
> http://dague.net
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to