Please don't send review requests to the list.  The preferred methods of
asking for reviews are discussed in this post:
http://lists.openstack.org/pipermail/openstack-dev/2013-September/015264.html

Thanks.

-Ben

On 10/22/2014 02:57 AM, Eli Qiao wrote:
> 
> hi all.
> when I am reviewing code of in nova/compute/manager.py
> I find that the detach_interface calls deallocate port from neutron first
> then calls detach_interface in the hypervisor, then what will happen if
> hypervisor detach_interface failed? the result is the port can be seen
> on guest but removed from neutron, this seems inconsistent.
> 
> I submit a patch [1] to propose remove port from neutron side after
> hypervisor
> detach_interface successfully, and keep neutron port if catch exception when
> detach_interface then give a log message.
> 
> can some one kindly help to take a look at it and give some comments?
> 
> [1] https://review.openstack.org/#/c/130151/
> 
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to