On 12/04/2014 01:44 PM, Stefano Maffulli wrote:
On 12/04/2014 09:24 AM, Anita Kuno wrote:
I think we move into very dangerous territory if we are equating a core
review Gerrit permission (it is just a Gerrit permission, if it is
perceived as anything other than that that is a perception we have
created ourselves) with value as an OpenStack contributor.
Forget the +2.  I would want Bob to have -2 capability on Neutron.

A -1 can be reset with just a new review. A -2 is the real power of core. The power to say "this is wrong, and you need to address it before it moves on."

And I say that as someone who has been on the receiving end of multiple -2s...



+2 to what Anita is saying.

We're talking about a tick box in gerrit and it's mostly a burden, an
obligation.

It's also a box that has been proven multiple times to be
bi-directional: sometimes people get to go work on other things, or get
called back in active duty, and reassigned as code janitors.

I haven't read anything but great comments and thank you notes for Bob
and Nati. They're both great developers and have taken good care of
Neutron's code. Once they're ready to get dirty again, it'll take only a
couple of weeks doing reviews to be picked.

Now, if you (and, more importantly, your employer) thinks that being
core reviewer is a honor and your bonus depends on it, contact me
offline to discuss this further.

Regards,
Stef

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to