I used to submit a patch and retrieve the reservation of quota, got a -2 because it can expire :)
so, I guess expire do no harm unless the uncommitted / unrollbacked reservation may occupy the quota and lead to side effect on upcoming actions... Best Regards! Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: [email protected] Phone: +86-10-82454158 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC From: Eli Qiao <[email protected]> To: "OpenStack Development Mailing List (not for usage questions)" <[email protected]> Date: 12/22/2014 11:37 AM Subject: Re: [openstack-dev] [nova][resend with correct subject prefix] ask for usage of quota reserve 在 2014年12月18日 17:33, Chen CH Ji 写道: AFAIK, quota will expire in 24 hours cfg.IntOpt('reservation_expire', default=86400, help='Number of seconds until a reservation expires'), Best Regards! hi Kevin, but that is not reliable, user/op can change the default value. shall we just leave as the quota reservation there can do not commit/rollback ? I don't think there will be much more we can do. Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: [email protected] Phone: +86-10-82454158 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC Inactive hide details for "Eli Qiao(Li Yong Qiao)" ---12/18/2014 04:34:32 PM---hi all, can anyone tell if we call quotas.reserv"Eli Qiao(Li Yong Qiao)" ---12/18/2014 04:34:32 PM---hi all, can anyone tell if we call quotas.reserve() but never call From: "Eli Qiao(Li Yong Qiao)" <[email protected]> To: "OpenStack Development Mailing List (not for usage questions)" <[email protected]> Date: 12/18/2014 04:34 PM Subject: [openstack-dev] [nova][resend with correct subject prefix] ask for usage of quota reserve hi all, can anyone tell if we call quotas.reserve() but never call quotas.commit() or quotas.rollback(). what will happen? for example: 1. when doing resize, we call quotas.reserve() to reservea a delta quota.(new_flavor - old_flavor) 2. for some reasons, nova-compute crashed, and not chance to call quotas.commit() or quotas.rollback() (called by finish_resize in nova/compute/manager.py) 3. next time restart nova-compute server, is the delta quota still reserved , or do we need any other operation on quotas? Thanks in advance -Eli. ps: this is related to patch : Handle RESIZE_PREP status when nova compute do init_instance(https://review.openstack.org/#/c/132827/) -- Thanks Eli Qiao([email protected]) _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Thanks, Eli (Li Yong) Qiao_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
