Overall looks good to me and the unit tests are passing locally. I'm wondering about some of the stuff that was left commented out without a FIXME and left a couple of comments about them, but I'm mostly assuming they were just things commented for testing that weren't removed later.
-Ben On 02/02/2015 03:59 PM, Doug Hellmann wrote: > > > On Mon, Feb 2, 2015, at 04:33 PM, Doug Hellmann wrote: >> I’ve prepared a copy of nova.objects as oslo_versionedobjects in >> https://github.com/dhellmann/oslo.versionedobjects-import. The script to >> create the repository is part of the update to the spec in >> https://review.openstack.org/152222. >> >> Please look over the code so you are familiar with it. Dan and I have >> already talked about the need to rewrite the tests that depend on nova’s >> service code, so those are set to skip for now. We’ll need to do some >> work to make the lib compatible with python 3, so I’ll make sure the >> project-config patch does not enable those tests, yet. >> >> Please post comments on the code here on the list in case I end up >> needing to rebuild that import repository. >> >> I’ll give everyone a few days before removing the WIP flag from the infra >> change to import this new repository >> (https://review.openstack.org/151792). > > I filed bugs for a few known issues that we'll need to work on before > the first release: https://bugs.launchpad.net/oslo.versionedobjects > > Doug > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev