On 03/04/2015 07:48 PM, GHANSHYAM MANN wrote:
> Hi Sean,
> 
> Yes having V3 directory/file names is very confusing now.
> 
> But current v3 sample tests cases tests v2.1 plugins. As /v3 url is
> redirected to v21 plugins, v3 sample tests make call through v3 url and
> test v2.1 plugins. 
> 
> I think we can start cleaning up the *v3* from everywhere and change it
> to v2.1 or much appropriate name.
> 
> To cleanup the same from sample files, I was planning to rearrange
> sample files structure. Please check if that direction looks good (still
> need to release patch for directory restructure)
> 
> https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:sample_files_structure,n,z
>  

Ok, so I'm confused, because v2 and v2.1 are supposed to be the same. So
all the v2 samples tests should be the ones that cover the v2.1 case. I
don't see why we'd have 2 versions in the stack.

Also these tests use the v3 pipeline, which means they actually use
different urls than v2 (that don't include the tenant). This discovery
all came with trying to remove the NoAuthMiddlewareV3 class.

So, we *definitely* should not have 2 sets of samples in tree. That's
just confusing and duplicative.

If the answer is retarget all of these to v2 end point, and delete
test_api_samples, that's also a good answer. But keeping both through
the release seems bad.

        -Sean

-- 
Sean Dague
http://dague.net

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to