On 04/01/2015 03:23 AM, Julien Danjou wrote:
The problem I see now, is that random people who has very little knowledge of $PROJECT or OpenStack as its whole jump in random review and put a -1 in Gerrit. And then never remove it. And then your patch is stuck for ever in review. Probably because we pushed people to review patches, because we needed review, etc. Personally this is hitting me back a lot and I'm getting more and more tired of that. How can you have people reviewing code when then never even wrote a patch on the project?
We encourage people to do code reviews as a way to get involved in the project, to learn about the code base, to learn from the core reviewer team. We encourage people to do bug fixing and commit useful patches in the same way.
If the core team won't take the time to help new contributors participate in the project, that is a problem with the core team members.
If you don't like someone's review feedback, tell them. Teach them and guide them to more productive contributions. If you don't speak up, you cannot expect the person to change their actions.
I've _never_ used only review numbers to put people to core reviewer. We had people trying to play the game that way, but I don't think you can become a core reviewer any code if you never fixed a bug nor wrote a patch in a project.
Show me a single person that is in a core team or that has been nominated for a core team that never pushed a patch or fixed a bug in the project.
Best, -jay __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
