On 21 April 2015 at 00:22, Victor Stinner <vstin...@redhat.com> wrote: >> I believe Redhat patch it out. I don't think they should need to, >> since we have explicit knobs for distros to use. > > pbr pulls pip which we don't want in RHEL. Example of patches in RDO: > > https://github.com/redhat-openstack/nova/commit/a19939c8f9a7b84b8a4d713fe3d26949e5664089 > https://github.com/redhat-openstack/python-keystoneclient/commit/e02d529a87aef8aaca0616c8ee81de224bf1f52a > https://github.com/redhat-openstack/neutron/commit/85302b75362df30270383e3a373e60e81b1b2384 > (well, it's always the same change) > > Can't we enhance pbr to build (source/wheel) distributions of applications > which don't depend on pbr? Basically implement these patches in pbr?
There is some fundamental misunderstanding here. http://docs.openstack.org/developer/pbr/packagers.html Firstly, pbr has no runtime dep on pip - it doesn't import it. So you don't need pip installed when an installed package uses pbr to get its version. Secondly, there are variables - see the link above - to control or override all the bits you could want. Lastly, pbr will use pkg_resources. > I read somewhere that pkg_resources may also be used to get the version. Yes, and pbr does that, when the package is installed. So - I still don't understand *why* RDO is patching it out. It needs one of the RDO packagers to file a bug describing what happens in sufficient detail that we can fix it. -Rob -- Robert Collins <rbtcoll...@hp.com> Distinguished Technologist HP Converged Cloud __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
