Yeah most of them are unit tests, but since the particular reviews I linked are actually moving the module they're importing, once that review merges it'll break their tests. So there would still need to be some decision made on how this is done. Doing the oslo.config attribute may make it easier to fix for them, so that is another option.
Thanks, Brandon On Fri, 2016-10-28 at 15:19 +0000, Sean M. Collins wrote: > It appears though that from the code search that it's all just based > on > unit tests, and overriding some configuration stuff. > > Since a lot of these unit test classes inherit from > Ml2PluginV2TestCase, > and it looks like there is a lot of copy & paste / cargo-cult that > occurred where the same line was copied across the stadium[1] to just > change some configuration before running unit tests, maybe we should > provide an attribute in Ml2PluginV2TestCase to get the oslo.config > instance so that overrides can be called? > > This is assuming I grok the problem, I've only had one cup of coffee > so > far.... > > [2]: http://codesearch.openstack.org/?q=ml2_config.cfg.CONF.set_overr > ide&i=nope&files=&repos= > > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
