On Tue, Aug 2, 2011 at 4:48 PM, Vishvananda Ishaya <[email protected]>wrote: > > > -1 The original purpose of the test was that people would add strings with > multiple positional replacement strings. This is hard to translate in some > cases, because the translators may need control over word order. We had a > series of 10 or so reviews, which was please convert your positional > replacement strings to keyword replacement strings. After a bunch of > reviews, someone finally wrote a test to verify it so we didn't have to > repeat it a million times. >
as a data point, I was ignorant of this positional replacement string issue, my code tripped this test, and I learned without a core dev having to explain. Definitely valuable. > > The original naive code was fine for that application. Your refactor is > very useful if you want to do some of the things you mentioned in 1., > otherwise the existing test was solving the one issue that we had. > > > > > Comments welcome. > > > > -- > > Zed A. Shaw > > http://zedshaw.com/ > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~openstack > > Post to : [email protected] > > Unsubscribe : https://launchpad.net/~openstack > > More help : https://help.launchpad.net/ListHelp > > > _______________________________________________ > Mailing list: https://launchpad.net/~openstack > Post to : [email protected] > Unsubscribe : https://launchpad.net/~openstack > More help : https://help.launchpad.net/ListHelp > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
