I had pep8 v1.2 in my virtual env from this: https://github.com/openstack/nova/commit/2fa2cd2254a4044aaa584c4fcf5d6c3e1ec60d1f#tools/test-requires
Rebased with trunk and re-creating my virtualenv (i.e. move back to pep8 v1.1) seemed to fix things. Thanks for your help, John > -----Original Message----- > From: Monty Taylor [mailto:[email protected]] > Sent: 02 July 2012 1:28 > To: John Garbutt > Cc: [email protected] > Subject: Re: [Openstack] PEP8 checks > > > > On 07/02/2012 06:46 AM, John Garbutt wrote: > > Hi, > > > > I noticed I can now run the pep8 tests like this (taken from Jenkins job): > > tox -v -epep8 > > ... > > pep8: commands succeeded > > congratulations :) > > > > But the old way to run tests seems to fail: > > ./run-tests.sh -p > > ... > > File > "/home/johngar/openstack/nova/.venv/local/lib/python2.7/site- > packages/pep8.py", line 1220, in check_logical > > for result in self.run_check(check, argument_names): > > TypeError: 'NoneType' object is not iterable > > > > Is this expected? > > Did I just miss an email about this change? > > I cannot reproduce this on my system. Can you run "bash -x run_tests.sh -p" > and pastebin the output? Also, tools/with_venv.sh pep8 --version just to be > sure. _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
