On Mon, Jul 9, 2012 at 3:01 PM, Dave Walker <[email protected]> wrote:
> On Mon, Jul 02, 2012 at 08:28:04AM -0400, Monty Taylor wrote: > > > > > > On 07/02/2012 06:46 AM, John Garbutt wrote: > > > Hi, > > > > > > I noticed I can now run the pep8 tests like this (taken from Jenkins > job): > > > tox -v -epep8 > > > ... > > > pep8: commands succeeded > > > congratulations :) > > > > > > But the old way to run tests seems to fail: > > > ./run-tests.sh -p > > > ... > > > File > "/home/johngar/openstack/nova/.venv/local/lib/python2.7/site-packages/pep8.py", > line 1220, in check_logical > > > for result in self.run_check(check, argument_names): > > > TypeError: 'NoneType' object is not iterable > > > > > > Is this expected? > > > Did I just miss an email about this change? > > > > I cannot reproduce this on my system. Can you run > > "bash -x run_tests.sh -p" and pastebin the output? Also, > > tools/with_venv.sh pep8 --version just to be sure. > > > > Hi, > > The issue is that as of a recent change to upstream pep8 [1], the > additional pep8 rules in tools/hacking.py need to be changed from > returns to yields.. :( > Proof of Concept: https://review.openstack.org/#/c/9569 > > [1] > https://github.com/jcrocholl/pep8/commit/b9f72b16011aac981ce9e3a47fd0ffb1d3d2e085 > > Kind Regards, > > Dave Walker <[email protected]> > Engineering Manager, > Ubuntu Server Infrastructure > > _______________________________________________ > Mailing list: https://launchpad.net/~openstack > Post to : [email protected] > Unsubscribe : https://launchpad.net/~openstack > More help : https://help.launchpad.net/ListHelp > >
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
