Hello community,
here is the log from the commit of package yast2-kdump for openSUSE:Factory
checked in at 2017-06-05 18:49:30
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-kdump (Old)
and /work/SRC/openSUSE:Factory/.yast2-kdump.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-kdump"
Mon Jun 5 18:49:30 2017 rev:81 rq:500692 version:3.2.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-kdump/yast2-kdump.changes 2017-04-12
17:08:39.799412935 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-kdump.new/yast2-kdump.changes
2017-06-05 18:49:32.092045045 +0200
@@ -1,0 +2,6 @@
+Fri Jun 2 13:44:40 UTC 2017 - gso...@suse.com
+
+- Added allocate memory high in commandline (FATE#320016)
+- 3.2.4
+
+-------------------------------------------------------------------
Old:
----
yast2-kdump-3.2.3.tar.bz2
New:
----
yast2-kdump-3.2.4.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-kdump.spec ++++++
--- /var/tmp/diff_new_pack.titMki/_old 2017-06-05 18:49:32.983919332 +0200
+++ /var/tmp/diff_new_pack.titMki/_new 2017-06-05 18:49:32.987918768 +0200
@@ -17,7 +17,7 @@
Name: yast2-kdump
-Version: 3.2.3
+Version: 3.2.4
Release: 0
Summary: Configuration of kdump
License: GPL-2.0
++++++ yast2-kdump-3.2.3.tar.bz2 -> yast2-kdump-3.2.4.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.2.3/package/yast2-kdump.changes
new/yast2-kdump-3.2.4/package/yast2-kdump.changes
--- old/yast2-kdump-3.2.3/package/yast2-kdump.changes 2017-03-30
10:40:36.685023378 +0200
+++ new/yast2-kdump-3.2.4/package/yast2-kdump.changes 2017-06-02
16:29:19.757793732 +0200
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Fri Jun 2 13:44:40 UTC 2017 - gso...@suse.com
+
+- Added allocate memory high in commandline (FATE#320016)
+- 3.2.4
+
+-------------------------------------------------------------------
Wed Mar 29 14:25:05 UTC 2017 - jreidin...@suse.com
- fix dumping kernel with Xen hypervisor (bsc#1014136)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.2.3/package/yast2-kdump.spec
new/yast2-kdump-3.2.4/package/yast2-kdump.spec
--- old/yast2-kdump-3.2.3/package/yast2-kdump.spec 2017-03-30
10:40:36.685023378 +0200
+++ new/yast2-kdump-3.2.4/package/yast2-kdump.spec 2017-06-02
16:29:19.757793732 +0200
@@ -17,7 +17,7 @@
Name: yast2-kdump
-Version: 3.2.3
+Version: 3.2.4
Release: 0
Summary: Configuration of kdump
License: GPL-2.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.2.3/src/clients/kdump.rb
new/yast2-kdump-3.2.4/src/clients/kdump.rb
--- old/yast2-kdump-3.2.3/src/clients/kdump.rb 2017-03-30 10:40:36.697023378
+0200
+++ new/yast2-kdump-3.2.4/src/clients/kdump.rb 2017-06-02 16:29:19.757793732
+0200
@@ -73,7 +73,7 @@
"handler" => fun_ref(method(:cmdKdumpStartup), "boolean (map)"),
# TRANSLATORS: CommandLine help
"help" => _("Start-up settings"),
- "example" => ["startup enable alloc_mem=256", "startup disable"]
+ "example" => ["startup enable alloc_mem=128,256", "startup
disable"]
},
"dumplevel" => {
"handler" => fun_ref(method(:cmdKdumpDumpLevel), "boolean (map)"),
@@ -229,10 +229,10 @@
"help" => _("Shows current option status")
},
"alloc_mem" => {
- "type" => "integer",
+ "type" => "string",
# TRANSLATORS: CommandLine help
"help" => _(
- "Size of allocated memory MB"
+ "Allocate Low and High Memory (in MB) of Kdump separated by
comma"
)
},
"dump_level" => {
@@ -740,7 +740,8 @@
if Ops.get(options, "enable") != nil &&
Ops.get(options, "alloc_mem") != nil
Kdump.add_crashkernel_param = true
- Kdump.allocated_memory = { low: options["alloc_mem"].to_s }
+ alloc_mem_low, alloc_mem_high = options["alloc_mem"].split(',')
+ Kdump.allocated_memory = { low: alloc_mem_low, high: alloc_mem_high }
#TRANSLATORS: CommandLine printed text
if Kdump.crashkernel_list_ranges
CommandLine.Print(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.2.3/test/client_test.rb
new/yast2-kdump-3.2.4/test/client_test.rb
--- old/yast2-kdump-3.2.3/test/client_test.rb 1970-01-01 01:00:00.000000000
+0100
+++ new/yast2-kdump-3.2.4/test/client_test.rb 2017-06-02 16:29:19.765793732
+0200
@@ -0,0 +1,41 @@
+require_relative "./test_helper"
+require_relative "../src/clients/kdump"
+
+describe Yast::KdumpClient do
+
+ describe ".cmdKdumpStartup" do
+ let(:alloc_mem_high) {"100"}
+ let(:alloc_mem_low) {"50"}
+
+ context "When using alloc memory high and low" do
+ let(:options) {{"enable"=>"",
"alloc_mem"=>"#{alloc_mem_low},#{alloc_mem_high}"}}
+
+ it "sets the low and high values of Kdump allocated_memory " do
+ subject.cmdKdumpStartup(options)
+ expect(Yast::Kdump.allocated_memory).to eq({low: alloc_mem_low,
+ high: alloc_mem_high})
+ expect(Yast::Kdump.add_crashkernel_param).to be true
+ end
+ end
+
+ context "when using only alloc memory low" do
+ let(:options) {{"enable"=>"", "alloc_mem"=>"#{alloc_mem_low}"}}
+
+ it "enables only the low value of Kdump allocated_memory " do
+ subject.cmdKdumpStartup(options)
+ expect(Yast::Kdump.allocated_memory).to eq({low: alloc_mem_low,
+ high: nil})
+ expect(Yast::Kdump.add_crashkernel_param).to be true
+ end
+ end
+
+ context "When receives the 'disable' option" do
+ let(:options) {{"disable"=>""}}
+
+ it "sets kdump to be disabled" do
+ subject.cmdKdumpStartup(options)
+ expect(Yast::Kdump.add_crashkernel_param).to be false
+ end
+ end
+ end
+end
