Hello community,
here is the log from the commit of package perl-Log-Dispatch-FileRotate for
openSUSE:Factory checked in at 2017-07-21 22:47:18
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Log-Dispatch-FileRotate (Old)
and /work/SRC/openSUSE:Factory/.perl-Log-Dispatch-FileRotate.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Log-Dispatch-FileRotate"
Fri Jul 21 22:47:18 2017 rev:22 rq:509391 version:1.27
Changes:
--------
---
/work/SRC/openSUSE:Factory/perl-Log-Dispatch-FileRotate/perl-Log-Dispatch-FileRotate.changes
2017-05-31 12:17:40.701880625 +0200
+++
/work/SRC/openSUSE:Factory/.perl-Log-Dispatch-FileRotate.new/perl-Log-Dispatch-FileRotate.changes
2017-07-21 22:47:19.586272093 +0200
@@ -1,0 +2,13 @@
+Fri Jul 7 05:44:58 UTC 2017 - [email protected]
+
+- updated to 1.27
+ see /usr/share/doc/packages/perl-Log-Dispatch-FileRotate/Changes
+
+ 1.27 Thu Jul 06 2017
+ - add "check_both" configuration option which allows the use of both
time and
+ size based rotation at the same time. If either conditions require a
+ rotation, a rotation will happen. Default is false (previous
behaviour).
+ Thanks Emanuele Tomasi. PR #6.
+ - make signature test an "author" test and make Test::Signature optional
+
+-------------------------------------------------------------------
Old:
----
Log-Dispatch-FileRotate-1.26.tar.gz
New:
----
Log-Dispatch-FileRotate-1.27.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Log-Dispatch-FileRotate.spec ++++++
--- /var/tmp/diff_new_pack.EP9DtF/_old 2017-07-21 22:47:20.338166029 +0200
+++ /var/tmp/diff_new_pack.EP9DtF/_new 2017-07-21 22:47:20.338166029 +0200
@@ -17,7 +17,7 @@
Name: perl-Log-Dispatch-FileRotate
-Version: 1.26
+Version: 1.27
Release: 0
%define cpan_name Log-Dispatch-FileRotate
Summary: Log to Files that Archive/Rotate Themselves
@@ -62,8 +62,8 @@
size mode. That is, use size values for deciding when to rotate.
Once DatePattern is defined FileRotate will move into time mode. Once this
-happens file rotation ignores size constraints and uses the defined date
-pattern constraints.
+happens file rotation ignores size constraints, unless check_both, and uses
+the defined date pattern constraints.
If you setup a config file using Log::Log4perl::init_and_watch() or the
like, you can switch between modes just by commenting out the DatePattern
++++++ Log-Dispatch-FileRotate-1.26.tar.gz ->
Log-Dispatch-FileRotate-1.27.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/Changes
new/Log-Dispatch-FileRotate-1.27/Changes
--- old/Log-Dispatch-FileRotate-1.26/Changes 2017-05-09 20:23:48.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.27/Changes 2017-07-06 17:48:44.000000000
+0200
@@ -1,5 +1,12 @@
Revision history for Perl extension Log::Dispatch::FileRotate.
+1.27 Thu Jul 06 2017
+ - add "check_both" configuration option which allows the use of both time
and
+ size based rotation at the same time. If either conditions require a
+ rotation, a rotation will happen. Default is false (previous behaviour).
+ Thanks Emanuele Tomasi. PR #6.
+ - make signature test an "author" test and make Test::Signature optional
+
1.26 Tue May 09 2017
- add SEE ALSO reference to Log::Dispath::File::Stamped (Thanks Karen
Etheridge)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/MANIFEST
new/Log-Dispatch-FileRotate-1.27/MANIFEST
--- old/Log-Dispatch-FileRotate-1.26/MANIFEST 2017-05-09 20:23:48.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.27/MANIFEST 2017-07-06 17:48:44.000000000
+0200
@@ -10,9 +10,9 @@
SIGNATURE
lib/Log/Dispatch/FileRotate.pm
t/author-pod-syntax.t
+t/author-signature.t
t/basic.t
t/file-open-failure.t
t/lockfile-open-failure.t
t/no-activity-bug.t
-t/signature.t
t/size-with-underscore.t
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/META.json
new/Log-Dispatch-FileRotate-1.27/META.json
--- old/Log-Dispatch-FileRotate-1.26/META.json 2017-05-09 20:23:48.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.27/META.json 2017-07-06 17:48:44.000000000
+0200
@@ -42,7 +42,6 @@
"requires" : {
"POSIX" : "0",
"Path::Tiny" : "0.018",
- "Socket" : "0",
"Test::More" : "0.88",
"Test::Warn" : "0",
"warnings" : "0"
@@ -62,7 +61,7 @@
"web" : "https://github.com/mschout/perl-log-dispatch-filerotate";
}
},
- "version" : "1.26",
+ "version" : "1.27",
"x_serialization_backend" : "Cpanel::JSON::XS version 3.0217"
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/META.yml
new/Log-Dispatch-FileRotate-1.27/META.yml
--- old/Log-Dispatch-FileRotate-1.26/META.yml 2017-05-09 20:23:48.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.27/META.yml 2017-07-06 17:48:44.000000000
+0200
@@ -5,7 +5,6 @@
build_requires:
POSIX: '0'
Path::Tiny: '0.018'
- Socket: '0'
Test::More: '0.88'
Test::Warn: '0'
warnings: '0'
@@ -33,5 +32,5 @@
bugtracker:
http://rt.cpan.org/Public/Dist/Display.html?Name=Log-Dispatch-FileRotate
homepage: http://search.cpan.org/dist/Log-Dispatch-FileRotate/
repository: git://github.com/mschout/perl-log-dispatch-filerotate.git
-version: '1.26'
+version: '1.27'
x_serialization_backend: 'YAML::Tiny version 1.69'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/Makefile.PL
new/Log-Dispatch-FileRotate-1.27/Makefile.PL
--- old/Log-Dispatch-FileRotate-1.26/Makefile.PL 2017-05-09
20:23:48.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.27/Makefile.PL 2017-07-06
17:48:44.000000000 +0200
@@ -30,12 +30,11 @@
"TEST_REQUIRES" => {
"POSIX" => 0,
"Path::Tiny" => "0.018",
- "Socket" => 0,
"Test::More" => "0.88",
"Test::Warn" => 0,
"warnings" => 0
},
- "VERSION" => "1.26",
+ "VERSION" => "1.27",
"test" => {
"TESTS" => "t/*.t"
}
@@ -51,7 +50,6 @@
"POSIX" => 0,
"Params::Validate" => 0,
"Path::Tiny" => "0.018",
- "Socket" => 0,
"Test::More" => "0.88",
"Test::Warn" => 0,
"base" => 0,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/README
new/Log-Dispatch-FileRotate-1.27/README
--- old/Log-Dispatch-FileRotate-1.26/README 2017-05-09 20:23:48.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.27/README 2017-07-06 17:48:44.000000000
+0200
@@ -1,7 +1,7 @@
This archive contains the distribution Log-Dispatch-FileRotate,
-version 1.26:
+version 1.27:
Log to Files that Archive/Rotate Themselves
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/SIGNATURE
new/Log-Dispatch-FileRotate-1.27/SIGNATURE
--- old/Log-Dispatch-FileRotate-1.26/SIGNATURE 2017-05-09 20:23:48.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.27/SIGNATURE 2017-07-06 17:48:44.000000000
+0200
@@ -14,36 +14,36 @@
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
-SHA1 8430d55b594734d92164f46651ef811b9e24d7aa Changes
+SHA1 5f2848a7a136999809d69d575eaa048911150c01 Changes
SHA1 bab88f54ea8c7c2588e407bd69fad8bf7cb47c1b LICENSE
-SHA1 b1bbf5c3f1e341251f8010786533366afa32ea61 MANIFEST
+SHA1 e8eda729f34b53e40683914c05a4f2514b7aa8c2 MANIFEST
SHA1 eb174e472fc75cb6a5a5f04e1dc740d569ad310b MANIFEST.SKIP
-SHA1 15b835cf4e7b014ee2495a3dccdccbbffb1cb7f8 META.json
-SHA1 8deb0ecf46eb27717736c7f9c2cc13d1265b4cb0 META.yml
-SHA1 a0a296d5626be35f3447449ed241b3b10da6dc95 Makefile.PL
-SHA1 b49c21c3c31dcd66be8f269c42056b8806e6c221 README
-SHA1 fe8448f1b9a996ad31a65c6eb15189714c07a28f lib/Log/Dispatch/FileRotate.pm
+SHA1 78eb2037a7f576b64612717a38021a7c732af909 META.json
+SHA1 92e3bb780fee17927d31cd6e109f59e2ad43406e META.yml
+SHA1 a444aa6dd3aa9efa9f9fdfc3fb308237a379a74e Makefile.PL
+SHA1 a9d40c8b3367a8e65c0e47bfda1350eb903928ed README
+SHA1 904fc63cbfc4c402cfe493f6173ef8c36fd4ea19 lib/Log/Dispatch/FileRotate.pm
SHA1 8efad25309730a4d501fb40fc03eda4697303372 t/author-pod-syntax.t
+SHA1 c985a5f343adfd44c02ddf90efa70d3601d1c34b t/author-signature.t
SHA1 1b0ff3264a10a8bbb678cc7cbec943d838fc7677 t/basic.t
SHA1 15be71bdf578a8bfc9f43a23751320c1e196ea8b t/file-open-failure.t
SHA1 7b7eeff7d92376f5a9ba9b4fe65869b3532c014e t/lockfile-open-failure.t
SHA1 ebfd5c0be8646d1e8c43515c5b745a63d3815955 t/no-activity-bug.t
-SHA1 f0c37746e0277de1ddb62c9227628a5ebe5a777a t/signature.t
SHA1 11e859568dfce86bbb2d75c0eb902199aa23fa7e t/size-with-underscore.t
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
-iQIVAwUBWRIJNKQl27WkM10aAQimRA/7Bel0UnyXk8pfFs9PObePrRvtqG7kKyHL
-aTC0qjuLgGv1Ab15xaNIfs2QdpxBgAVubTVjEj/AB+lRwTTWEwKA1TSCXPC0pcrQ
-SsJGyceJjOKUq8KTgIa0+VQxhtxlHagi3l7I34O9vHJ7TZW8j7vVl88V1WIbOMev
-NgMVMcySThavIfYzMGs0SDCS6EM5Q0469s4kQxeQWyYBnU0Nmx+0nWSKQs4useE3
-wGf+0Rx5ZeeeSH87Hs1q6JvOD/yhYQg+gzGLhn/2iby7oP0Nkm3v3v9ViJHKSPXo
-ugLEx+zWoYXRLWCeoUjFMHFvt8F3uc+DLFFQdNFiVe87Lgconxs1qz9vJVa+qAZo
-zYQplAMs2FBZVyVth+0q+n8X8s/CYFSAD9KUnoO0WiuVRyLoFEIqN8hWFBn/mo+Z
-FMcxTAv65KYGICyD9y3LEYTs/Gc8/LyyAmWuDUEJvcrXbld8r1xR074/VWI4VlQY
-h4nPIwiV4pNeywFjdD0KQ/0v6xhXV6h9aUXVx3sgZZ+kmi8lLfwIJUIPRPjZT25s
-//6AEeztgQ1qJeiqvKBIlm+ul+/z4InmPfziGfVRysVZ2GrCH1UNleD7GFGYTuDc
-z+xL40pwe/bPXwP4hQ/IqCZAbizBPpziZukIgRjLq3USswiNIxd5B8YVr+MCVZWD
-DhukY9fpYOk=
-=YIpm
+iQIVAwUBWV5b3KQl27WkM10aAQh0PRAA4F/P6I8FUjNf0xODcHyMVwjvFIEsmrKi
+B1NW+Gjfm19KCfop3O236TjqGXM9s5vokQU9X6dRWwCjsB2SfXHsBauJwE5UV5au
+yR3EKeiarii1/L8uy8nCHtTwNQWaO7V31zE6QYDq3Dtfz/pwKC6Qp/qrLeYgPKMM
+ZKo2ZLVW72uCZgzS9d71c7HtyiPQr6tb/puvSzIZ/3vf523WHKCQzdR6LciHxqbp
+ZvWju6j19idDX5oCKRlw274/AwWsiAq+OSpJNi2xCRXAszjVlvK4WYbKVS3ZRqeR
+AGuW4/gQi+SQPlRp9UgQHBNUUaOfwif6BDXWA89V/SnRVdAr9j+VbS5NIy2f/CRG
+Rm2NXLyj5AiegWkt7LFxI1p2vHkkIGbveq4HRJrVsXMScJAl0qGfDV9kX13TqMCN
+cQLHB9og7vkZ3F0OajRZetvlEeUipDLEY7jRtIBQAS+Emc+JjTD0LwToW1siCky4
+4ZM5VmtEmqxgj+qF/ILp5IzCscui6V+vNuMFXK1yBAb+N9TyHMe5yfmxzgNWKJdQ
+xYgf8+W3PDUCXhhdGlynsonQdIPcJrkJ+E8JJSQ64agGyEAD/eSKphD8WOSZU6I1
+jvG88WeLAl5pZDOoFoLY2pm0A268wwO6Q3KNzykl1mAX1cPnQdQXv0Oet6jrJzTP
++JuANW5xGms=
+=eNkv
-----END PGP SIGNATURE-----
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Log-Dispatch-FileRotate-1.26/lib/Log/Dispatch/FileRotate.pm
new/Log-Dispatch-FileRotate-1.27/lib/Log/Dispatch/FileRotate.pm
--- old/Log-Dispatch-FileRotate-1.26/lib/Log/Dispatch/FileRotate.pm
2017-05-09 20:23:48.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.27/lib/Log/Dispatch/FileRotate.pm
2017-07-06 17:48:44.000000000 +0200
@@ -1,5 +1,5 @@
package Log::Dispatch::FileRotate;
-$Log::Dispatch::FileRotate::VERSION = '1.26';
+$Log::Dispatch::FileRotate::VERSION = '1.27';
# ABSTRACT: Log to Files that Archive/Rotate Themselves
require 5.005;
@@ -89,6 +89,8 @@
$self->setDatePattern($p{'DatePattern'});
}
+ $self->{check_both} = ($p{check_both}) ? 1 : 0;
+
# Flag this as first creation point
$self->{'new'} = 1;
@@ -213,6 +215,7 @@
warn "$$ got lock after wait\n" if $self->{debug};
}
+ my $have_to_rotate = 0;
my $size = (stat($fh))[7]; # Stat the handle to get real size
my $inode = (stat($fh))[1]; # get real inode
my $finode = (stat($name))[1]; # Stat the name for comparision
@@ -222,7 +225,6 @@
# If finode and inode are the same then nobody has done a rename
# under us and we can continue. Otherwise just close and reopen.
- # Time mode overrides Size mode
if(!defined($finode) || $inode != $finode)
{
# Oops someone moved things on us. So just reopen our log
@@ -230,22 +232,24 @@
$self->{LDF} = Log::Dispatch::File->new(%{$self->{params}});
# Our log
warn localtime()." $$ Someone else rotated: normal log\n" if
$self->{debug};
- $self->logit($p{message});
- }
- elsif($in_time_mode && !$time_to_rotate)
- {
- warn localtime()." $$ In time mode: normal log\n" if
$self->{debug};
- $self->logit($p{message});
}
- elsif(!$in_time_mode && defined($size) && $size < $max_size )
+ else
{
- warn localtime()." $$ In size mode: normal log\n" if
$self->{debug};
- $self->logit($p{message});
+ my $check_both = $self->{check_both};
+ my $rotate_by_size = ($size >= $max_size) ? 1 : 0;
+ if(($in_time_mode && $time_to_rotate) ||
+ (!$in_time_mode && $rotate_by_size) ||
+ ($rotate_by_size && $check_both))
+ {
+ $have_to_rotate = 1;
+ }
+
+ warn localtime()." $$ in time mode: $in_time_mode; time to
rotate: $time_to_rotate;"
+ ." rotate by size: $rotate_by_size; check_both:
$check_both;"
+ ." have to rotate: $have_to_rotate\n" if $self->{debug};
}
- # Need to rotate
- elsif(($in_time_mode && $time_to_rotate) ||
- (!$in_time_mode && $size)
- )
+
+ if($have_to_rotate)
{
# Shut down the log
delete $self->{LDF}; # Should get rid of current LDF
@@ -275,10 +279,9 @@
# Write it out
warn localtime()." $$ rotated: normal log\n" if $self->{debug};
- $self->logit($p{message});
}
- #else size is zero :-} just don't do anything!
+ $self->logit($p{message});
$self->lfhunlock();
}
@@ -677,7 +680,7 @@
=head1 VERSION
-version 1.26
+version 1.27
=head1 SYNOPSIS
@@ -720,9 +723,9 @@
of files defaults to 1. If DatePattern is not defined then we default to
working in size mode. That is, use size values for deciding when to rotate.
-Once DatePattern is defined FileRotate will move into time mode. Once
-this happens file rotation ignores size constraints and uses the defined
-date pattern constraints.
+Once DatePattern is defined FileRotate will move into time mode. Once this
+happens file rotation ignores size constraints, unless check_both, and uses
+the defined date pattern constraints.
If you setup a config file using Log::Log4perl::init_and_watch() or the
like, you can switch between modes just by commenting out the DatePattern
@@ -783,6 +786,10 @@
The DatePattern as defined above.
+=item -- check_both ($)
+
+1 for checking both constrains, 0 otherwise (the default).
+
=item -- min_level ($)
The minimum logging level this object will accept. See the
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/t/author-signature.t
new/Log-Dispatch-FileRotate-1.27/t/author-signature.t
--- old/Log-Dispatch-FileRotate-1.26/t/author-signature.t 1970-01-01
01:00:00.000000000 +0100
+++ new/Log-Dispatch-FileRotate-1.27/t/author-signature.t 2017-07-06
17:48:44.000000000 +0200
@@ -0,0 +1,20 @@
+#!perl -w
+
+BEGIN {
+ unless ($ENV{AUTHOR_TESTING}) {
+ print qq{1..0 # SKIP these tests are for testing by the author\n};
+ exit
+ }
+}
+
+
+use strict;
+use warnings;
+use Test::More;
+
+unless (eval { require Test::Signature; 1 }) {
+ plan skip_all => 'Test::Signature is required for this test';
+}
+
+Test::Signature::signature_ok();
+done_testing;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.26/t/signature.t
new/Log-Dispatch-FileRotate-1.27/t/signature.t
--- old/Log-Dispatch-FileRotate-1.26/t/signature.t 2017-05-09
20:23:48.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.27/t/signature.t 1970-01-01
01:00:00.000000000 +0100
@@ -1,36 +0,0 @@
-#!perl -w
-
-## Test that our SIGNATURE file is valid
-
-use Test::More;
-use strict;
-
-if (!$ENV{TEST_SIGNATURE}) {
- plan skip_all =>
- "Set the environment variable TEST_SIGNATURE to enable this test.";
-}
-elsif (!eval { require Module::Signature; 1 }) {
- plan skip_all =>
- "Please install Module::Signature so that you can verify ".
- "the integrity of this and other distributions.";
-}
-elsif (!-e 'SIGNATURE') {
- plan skip_all => "SIGNATURE file was not found";
-}
-elsif (-s 'SIGNATURE' == 0) {
- plan skip_all => "SIGNATURE file was empty";
-}
-elsif (!eval { require Socket; Socket::inet_aton('pgp.mit.edu') }) {
- plan skip_all =>
- "Cannot connect to the keyserver to check module signature";
-}
-else {
- plan tests => 1;
-}
-
-my $ret = Module::Signature::verify(skip => 1);
-SKIP: {
- skip "Module::Signature cannot verify", 1
- if $ret eq Module::Signature::CANNOT_VERIFY();
- cmp_ok $ret, '==', Module::Signature::SIGNATURE_OK(), "Valid
signature";
-}
