Hello community,

here is the log from the commit of package perl-Log-Dispatch-FileRotate for 
openSUSE:Factory checked in at 2017-09-04 12:36:46
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Log-Dispatch-FileRotate (Old)
 and      /work/SRC/openSUSE:Factory/.perl-Log-Dispatch-FileRotate.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "perl-Log-Dispatch-FileRotate"

Mon Sep  4 12:36:46 2017 rev:24 rq:520427 version:1.30

Changes:
--------
--- 
/work/SRC/openSUSE:Factory/perl-Log-Dispatch-FileRotate/perl-Log-Dispatch-FileRotate.changes
        2017-08-28 15:10:35.276207103 +0200
+++ 
/work/SRC/openSUSE:Factory/.perl-Log-Dispatch-FileRotate.new/perl-Log-Dispatch-FileRotate.changes
   2017-09-04 12:36:47.483553819 +0200
@@ -1,0 +2,14 @@
+Tue Aug 15 05:42:33 UTC 2017 - [email protected]
+
+- updated to 1.30
+   see /usr/share/doc/packages/perl-Log-Dispatch-FileRotate/Changes
+
+  1.30 Thu Aug 03 2017
+      - Docs: fix synopsis usage to "name" (incorrect) instead of filename
+        (correct) (Thanks Emanuele Tomasi)
+      - improve debug() routine so that all debug messages have the same layout
+        (Thanks Emanuele Tomasi)
+      - fix race condition in lockfile-race-condition.t [sic] (Thanks Emanuele
+        Tomasi)
+
+-------------------------------------------------------------------

Old:
----
  Log-Dispatch-FileRotate-1.29.tar.gz

New:
----
  Log-Dispatch-FileRotate-1.30.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ perl-Log-Dispatch-FileRotate.spec ++++++
--- /var/tmp/diff_new_pack.G4897J/_old  2017-09-04 12:36:49.423280917 +0200
+++ /var/tmp/diff_new_pack.G4897J/_new  2017-09-04 12:36:49.439278666 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           perl-Log-Dispatch-FileRotate
-Version:        1.29
+Version:        1.30
 Release:        0
 %define cpan_name Log-Dispatch-FileRotate
 Summary:        Log to Files that Archive/Rotate Themselves

++++++ Log-Dispatch-FileRotate-1.29.tar.gz -> 
Log-Dispatch-FileRotate-1.30.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.29/Changes 
new/Log-Dispatch-FileRotate-1.30/Changes
--- old/Log-Dispatch-FileRotate-1.29/Changes    2017-07-28 17:15:44.000000000 
+0200
+++ new/Log-Dispatch-FileRotate-1.30/Changes    2017-08-03 22:33:46.000000000 
+0200
@@ -1,5 +1,13 @@
 Revision history for Perl extension Log::Dispatch::FileRotate.
 
+1.30 Thu Aug 03 2017
+    - Docs: fix synopsis usage to "name" (incorrect) instead of filename
+      (correct) (Thanks Emanuele Tomasi)
+    - improve debug() routine so that all debug messages have the same layout
+      (Thanks Emanuele Tomasi)
+    - fix race condition in lockfile-race-condition.t [sic] (Thanks Emanuele
+      Tomasi)
+
 1.29 Fri Jul 28 2017
     - Fix deadlock on Windows due to the fact that stat() on a filehandle vs a
       path doesn't return the same device field on Windows.
@@ -53,8 +61,6 @@
       installed and only run if TEST_SIGNATURE=1 is passed to make test)
     - Docs: fix synopsis reference to size parameter to make it clear that
       the size is in bytes, not megabytes.  [#88286]
-    - Docs: fix synopsis usage to "name" (incorrect) instead of filename
-      (correct)
 
 1.21
     [REMOVED] - accidental release, bad dist.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.29/META.json 
new/Log-Dispatch-FileRotate-1.30/META.json
--- old/Log-Dispatch-FileRotate-1.29/META.json  2017-07-28 17:15:44.000000000 
+0200
+++ new/Log-Dispatch-FileRotate-1.30/META.json  2017-08-03 22:33:46.000000000 
+0200
@@ -16,11 +16,18 @@
    "prereqs" : {
       "configure" : {
          "requires" : {
-            "ExtUtils::MakeMaker" : "0"
+            "ExtUtils::MakeMaker" : "0",
+            "perl" : "5.006"
          }
       },
       "develop" : {
          "requires" : {
+            "Dist::Zilla" : "5",
+            "Dist::Zilla::Plugin::NextRelease" : "0",
+            "Dist::Zilla::Plugin::RemovePrereqs" : "0",
+            "Dist::Zilla::PluginBundle::Filter" : "0",
+            "Dist::Zilla::PluginBundle::MSCHOUT" : "0",
+            "Software::License::Perl_5" : "0",
             "Test::Pod" : "1.41"
          }
       },
@@ -33,7 +40,7 @@
             "Log::Dispatch::Output" : "0",
             "Params::Validate" : "0",
             "base" : "0",
-            "perl" : "5.005",
+            "perl" : "5.006",
             "strict" : "0",
             "version" : "0"
          }
@@ -44,6 +51,7 @@
             "Path::Tiny" : "0.018",
             "Test::More" : "0.88",
             "Test::Warn" : "0",
+            "perl" : "5.006",
             "warnings" : "0"
          }
       }
@@ -61,7 +69,7 @@
          "web" : "https://github.com/mschout/perl-log-dispatch-filerotate";
       }
    },
-   "version" : "1.29",
+   "version" : "1.30",
    "x_serialization_backend" : "Cpanel::JSON::XS version 3.0217"
 }
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.29/META.yml 
new/Log-Dispatch-FileRotate-1.30/META.yml
--- old/Log-Dispatch-FileRotate-1.29/META.yml   2017-07-28 17:15:44.000000000 
+0200
+++ new/Log-Dispatch-FileRotate-1.30/META.yml   2017-08-03 22:33:46.000000000 
+0200
@@ -7,9 +7,11 @@
   Path::Tiny: '0.018'
   Test::More: '0.88'
   Test::Warn: '0'
+  perl: '5.006'
   warnings: '0'
 configure_requires:
   ExtUtils::MakeMaker: '0'
+  perl: '5.006'
 dynamic_config: 0
 generated_by: 'Dist::Zilla version 6.009, CPAN::Meta::Converter version 
2.150005'
 license: perl
@@ -25,12 +27,12 @@
   Log::Dispatch::Output: '0'
   Params::Validate: '0'
   base: '0'
-  perl: '5.005'
+  perl: '5.006'
   strict: '0'
   version: '0'
 resources:
   bugtracker: 
http://rt.cpan.org/Public/Dist/Display.html?Name=Log-Dispatch-FileRotate
   homepage: http://search.cpan.org/dist/Log-Dispatch-FileRotate/
   repository: git://github.com/mschout/perl-log-dispatch-filerotate.git
-version: '1.29'
+version: '1.30'
 x_serialization_backend: 'YAML::Tiny version 1.69'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.29/Makefile.PL 
new/Log-Dispatch-FileRotate-1.30/Makefile.PL
--- old/Log-Dispatch-FileRotate-1.29/Makefile.PL        2017-07-28 
17:15:44.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.30/Makefile.PL        2017-08-03 
22:33:46.000000000 +0200
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use 5.005;
+use 5.006;
 
 use ExtUtils::MakeMaker;
 
@@ -14,7 +14,7 @@
   },
   "DISTNAME" => "Log-Dispatch-FileRotate",
   "LICENSE" => "perl",
-  "MIN_PERL_VERSION" => "5.005",
+  "MIN_PERL_VERSION" => "5.006",
   "NAME" => "Log::Dispatch::FileRotate",
   "PREREQ_PM" => {
     "Date::Manip" => 0,
@@ -34,7 +34,7 @@
     "Test::Warn" => 0,
     "warnings" => 0
   },
-  "VERSION" => "1.29",
+  "VERSION" => "1.30",
   "test" => {
     "TESTS" => "t/*.t"
   }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.29/README 
new/Log-Dispatch-FileRotate-1.30/README
--- old/Log-Dispatch-FileRotate-1.29/README     2017-07-28 17:15:44.000000000 
+0200
+++ new/Log-Dispatch-FileRotate-1.30/README     2017-08-03 22:33:46.000000000 
+0200
@@ -1,7 +1,7 @@
 
 
 This archive contains the distribution Log-Dispatch-FileRotate,
-version 1.29:
+version 1.30:
 
   Log to Files that Archive/Rotate Themselves
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.29/SIGNATURE 
new/Log-Dispatch-FileRotate-1.30/SIGNATURE
--- old/Log-Dispatch-FileRotate-1.29/SIGNATURE  2017-07-28 17:15:44.000000000 
+0200
+++ new/Log-Dispatch-FileRotate-1.30/SIGNATURE  2017-08-03 22:33:46.000000000 
+0200
@@ -14,18 +14,18 @@
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA256
 
-SHA1 117fb6a8ebe95e7bc99da90302d2ab6c601a658a Changes
+SHA1 3a602e6780f7b60aa4eb1a29a9e4f1a9bbfd100b Changes
 SHA1 bab88f54ea8c7c2588e407bd69fad8bf7cb47c1b LICENSE
 SHA1 4a7726f10a2d40e2ddf0907f67e92453f03e466a MANIFEST
 SHA1 eb174e472fc75cb6a5a5f04e1dc740d569ad310b MANIFEST.SKIP
-SHA1 b80a323a6a0a20509667e20879f6e3809010e9ff META.json
-SHA1 8ab48a984f989b1e156c1543f53f0cf4a9ec7878 META.yml
-SHA1 95b3d9dfc8f9c0522d58d0626377b26365372ba8 Makefile.PL
-SHA1 4f55a0709453c16ee46a1f7ede1de6c4f6ce83d4 README
-SHA1 6baf938139d4ed75d632f2b1d68e100991c5d766 lib/Log/Dispatch/FileRotate.pm
-SHA1 468e2f4cfd487b11e031a13ac79a56b2cc502d23 
t/author-lockfile-race-condition.t
+SHA1 66cfd024c8106a83fa2c16d48b2f8cb88728243f META.json
+SHA1 65f7e36843f1a451495c777255f2cd8a0f2cc1e4 META.yml
+SHA1 a7d337efacf1e35b7f20a1ce939abe0dc6e293eb Makefile.PL
+SHA1 53daed22e1063f3296ec4fdc97304cdcbd576e0d README
+SHA1 cc766361770b8b40fd3c94d3011f82159fcda9cf lib/Log/Dispatch/FileRotate.pm
+SHA1 2795a301bfcb88ecd1eb29bc1be9fa7610acbb42 
t/author-lockfile-race-condition.t
 SHA1 8efad25309730a4d501fb40fc03eda4697303372 t/author-pod-syntax.t
-SHA1 c985a5f343adfd44c02ddf90efa70d3601d1c34b t/author-signature.t
+SHA1 19cc343f8a85c6805bbeb02580487483a6283887 t/author-signature.t
 SHA1 1b0ff3264a10a8bbb678cc7cbec943d838fc7677 t/basic.t
 SHA1 15be71bdf578a8bfc9f43a23751320c1e196ea8b t/file-open-failure.t
 SHA1 7b7eeff7d92376f5a9ba9b4fe65869b3532c014e t/lockfile-open-failure.t
@@ -34,17 +34,17 @@
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2
 
-iQIVAwUBWXtVIKQl27WkM10aAQhqkg//Znl8z8bxvhcA1NcdSGRT6n0eSqkh4RTx
-ag86+NcSFIMBrKf8I49T3zGJpUSgYvafT2PFhGvRlpL74yaAQmfS6nLa+tJv/ZsX
-fj2TL6U9Oi+KpppkWXSPvbHL5mCwJq576lnVzLec8AcbfRLKJVungzCLOd3DZxdM
-dA6PbYyA9QIUlt3iVhY8U3m4OYGB9Exu2Odb9I5oMDiIRPA6TMkOpCQcBXVjWXqn
-Qlbf9RaqsOMAPRgivYEk/74NFbgZkmzKRcp7yjnzg56s+xAJfV3StrpIwrjv850q
-hPxsnXC9R4rq1n2d1Bz1JZXfuqOb/Q9QIPtgGdov5ySxoy1Hxh8LZNv8zLqcb/i1
-Md6s6jLcC0MxkhJE7oALLXgHLTYg8jCqPyu3COSz8PSeTZKfsnRzmtH31X4Qou2j
-zsFdJKYq/mT+GD03RmwR+4BhV+MyHOnY0pHYT58xkXxvHU7jM0xQ9nQ+BZBsscx9
-yN0pPKERMK9Yt7IHq3sISuMZdkKBFtn2qVT/TQ96BqYhDA54QH9O3R3QIqUfr23o
-NNcJtLQMVxOHn5C+XEBwAYYR9Gz8SdSnhyVhofllj0CzLv6yVYwXT3WvhA8O19jT
-tgQlTOoOlskqqKyG6x4gwlUZsTR2wnPnpclCPFN5o3PvtSEfFHWayjXSWmAipJ0b
-htiV0L/Mn+A=
-=g55+
+iQIVAwUBWYOIqqQl27WkM10aAQh8xg/+NE1ZqcinAbRBbf63Vz7ERU22ms8vLcyl
+Z0J2A5J5dp8sb7PdAmnE3NJ7kR6MtjOw5p43sQYcmsvjXuX9/xNXbA7x17M70fsN
+RjSNIEHjTwB3AI4h09MrUxCpkJQGBlUh9lq63TfOyLxFG0wyumYmdYXXo9iAQjV6
+st9ST4RBwfAT2Z/l21JbmRORuue5kRnsOD0B8pAwzDfcCXccbX52IY+RKInHipV5
+fL7RSTcShfleMzVW3+p4pbXHi3Bh/NRmNzt7A1mnqI5TR7FZr9EpN1a3gDOMGgji
+W5AbC1yOnaE8JDhsin8AEkN2dciiziST8GsfueFwZyRMBp0YfTVMRDeVsdnW9qXo
+ITkAbtJOGvwCuSEssn21Y9l35jdQeCXK+eKMYLvSYoUEpc9ZWdsnHmZ6HGl7hV/R
+DKJHWV+tEP9HwA+8jclyrO+VeXZBqPwws3xyWdUFAsQdp4K5UcKE+l7FhfxIU2Lo
+cwzTHK9Va+8n90wLaPVDMTlZHZDGzIqoSfqBlbQUJ8rKWdgtsVDDZkQ706GuFbYX
+VxHa0Ht9EOgSCzTjMaokkhBzDOxPp95d17azmqkHI0Gz4q9iSdF21CHQOjSpu8CR
+lQU455L3X6JyU699nN3/sNqq222T0AjS1ary/JucRSYfdBhSxf8fTjcdPqpGVRXS
+6D4+3QDayfY=
+=Qt41
 -----END PGP SIGNATURE-----
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/Log-Dispatch-FileRotate-1.29/lib/Log/Dispatch/FileRotate.pm 
new/Log-Dispatch-FileRotate-1.30/lib/Log/Dispatch/FileRotate.pm
--- old/Log-Dispatch-FileRotate-1.29/lib/Log/Dispatch/FileRotate.pm     
2017-07-28 17:15:44.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.30/lib/Log/Dispatch/FileRotate.pm     
2017-08-03 22:33:46.000000000 +0200
@@ -1,5 +1,5 @@
 package Log::Dispatch::FileRotate;
-$Log::Dispatch::FileRotate::VERSION = '1.29';
+$Log::Dispatch::FileRotate::VERSION = '1.30';
 # ABSTRACT: Log to Files that Archive/Rotate Themselves
 
 require 5.005;
@@ -28,7 +28,8 @@
 
     my $self = bless {}, $class;
 
-       $self->{'debug'} = 0;
+       # Turn ON/OFF debugging as required
+       $self->{debug} = $p{DEBUG};
     $self->_basic_init(%p);
     $self->{'LDF'} =  Log::Dispatch::File->new(%p);  # Our log
        $self->{'timer'} = sub { time() } unless defined $self->{'timer'};
@@ -36,9 +37,6 @@
        # Keep a copy of interesting stuff as well
        $self->{params} = \%p;
 
-       # Turn ON/OFF debugging as required
-       $p{'DEBUG'} ? $self->debug(1) : $self->debug(0);
-       
        # Size defaults to 10meg in all failure modes, hopefully
        my $ten_meg = 1024*1024*10;
        my $two_gig = 1024*1024*1024*2;
@@ -63,7 +61,7 @@
        $f = $name unless $f;
 
        my $lockfile = File::Spec->catpath($vol, $dir, ".".$f.".LCK");
-       warn "Lock file is $lockfile\n" if $self->{'debug'};
+       $self->debug("Lock file is $lockfile");
        $self->{lf} = $lockfile;
 
        # Have we been called with a time based rotation pattern then setup
@@ -181,7 +179,7 @@
                }
 
                my $abs = $self->_get_next_occurance($pat);
-               warn "Adding [dates,pat] =>[$abs,$pat]\n" if $self->{debug};
+               $self->debug("Adding [dates,pat] =>[$abs,$pat]");
                my $ref = [$abs, $pat];
                push(@{$self->{'recurrance'}}, $ref);
 
@@ -213,15 +211,15 @@
                return;
        }
 
-       warn "$$ got lock\n" if $self->{debug};
+       $self->debug("got lock");
 
        my $have_to_rotate = 0;
        my $size   = (stat($fh))[7];   # Stat the handle to get real size
        my $inode  = (stat($fh))[1];   # get real inode
        my $finode = (stat($name))[1]; # Stat the name for comparision
-       warn localtime()." $$  s=$size, i=$inode, f=".
+       $self->debug("s=$size, i=$inode, f=".
                        (defined $finode ? $finode : "undef") .
-                        ", n=$name\n" if $self->{debug};
+                       ", n=$name");
 
        # If finode and inode are the same then nobody has done a rename
        # under us and we can continue. Otherwise just close and reopen.
@@ -231,7 +229,7 @@
                delete $self->{LDF};  # Should get rid of current LDF
                $self->{LDF} =  Log::Dispatch::File->new(%{$self->{params}});  
# Our log
 
-               warn localtime()." $$ Someone else rotated: normal log\n" if 
$self->{debug};
+               $self->debug("Someone else rotated: normal log");
        }
        else
        {
@@ -244,9 +242,9 @@
                        $have_to_rotate = 1;
                }
 
-               warn localtime()." $$ in time mode: $in_time_mode; time to 
rotate: $time_to_rotate;"
+               $self->debug("in time mode: $in_time_mode; time to rotate: 
$time_to_rotate;"
                        ." rotate by size: $rotate_by_size; check_both: 
$check_both;"
-                       ." have to rotate: $have_to_rotate\n" if $self->{debug};
+                       ." have to rotate: $have_to_rotate");
        }
 
        if($have_to_rotate)
@@ -256,33 +254,34 @@
 
                my $idx = $numfiles -1;
 
-               warn localtime() . " $$ Rotating\n" if $self->{debug};
+               $self->debug("Rotating");
                while($idx >= 0)
                {
                        if($idx <= 0)
                        {
-                               warn "$$ rename $name $name.1\n" if 
$self->{debug};
+                               $self->debug("rename $name $name.1");
                                rename($name, "$name.1");
                        }
                        else
                        {
-                               warn "$$ rename $name.$idx 
$name.".($idx+1)."\n" if $self->{debug};
+                               $self->debug("rename $name.$idx 
$name.".($idx+1));
                                rename("$name.$idx", "$name.".($idx+1));
                        }
 
                        $idx--;
                }
-               warn localtime() . " $$ Rotating Done\n" if $self->{debug}; 
+               $self->debug("Rotating Done");
 
                # reopen the logfile for writing.
                $self->{LDF} =  Log::Dispatch::File->new(%{$self->{params}});  
# Our log
 
                # Write it out
-               warn localtime()." $$ rotated: normal log\n" if $self->{debug};
+               $self->debug("rotated: normal log");
        }
 
        $self->logit($p{message});
 
+       $self->debug("releasing lock");
        safe_flock($lfh, LOCK_UN);
 }
 
@@ -374,13 +373,13 @@
                                if($ftime <= $abs)
                                {
                                        # Then we need to rotate
-                                       warn "Need rotate file($ftime) <= 
$abs\n" if $self->{debug};
+                                       $self->debug("Need rotate file($ftime) 
<= $abs");
                                        $rotate++;
                                        $dorotate++;  # Just for debugging
                                }
 
                                # Move to next occurance regardless
-                               warn "Dropping initial occurance($abs)\n" if 
$self->{debug};
+                               $self->debug("Dropping initial 
occurance($abs)");
                                $abs = $self->_get_next_occurance($pat);
                                unless(defined $abs && $abs)
                                {
@@ -393,7 +392,7 @@
                        elsif($abs <= $tm)
                        {
                                # Then we need to rotate
-                               warn "Need rotate $abs <= $tm\n" if 
$self->{debug};
+                               $self->debug("Need rotate $abs <= $tm");
                                $abs = $self->_get_next_occurance($pat);
                                unless(defined $abs && $abs)
                                {
@@ -404,14 +403,14 @@
                                $dorotate++;  # Just for debugging
                        }
                        push(@{$self->{'recurrance'}},[$abs,$pat]) if $abs;
-                       warn "time_to_rotate(mode,rotate,next) => 
($mode,$dorotate,$abs)\n" if $self->{debug};
+                       $self->debug("time_to_rotate(mode,rotate,next) => 
($mode,$dorotate,$abs)");
                }
                
        }
 
        $self->{'new'} = 0;  # No longer brand-spankers
 
-       warn "time_to_rotate(mode,rotate) => ($mode,$rotate)\n" if 
$self->{debug};
+       $self->debug("time_to_rotate(mode,rotate) => ($mode,$rotate)");
        return wantarray ? ($mode,$rotate) : $rotate;
 }
 
@@ -477,7 +476,7 @@
        # we may rotate for every message we recieve with in this second :-(
        my $start = DateCalc($base,"+ 1 second");
 
-       warn "ParseRecur($pat,$base,$start,$range);\n" if $self->{debug};
+       $self->debug("ParseRecur($pat,$base,$start,$range);");
        my @dates = ParseRecur($pat,$base,$start,$range);
 
        # Just in case we have a bad parse or our assumptions are wrong.
@@ -500,10 +499,7 @@
        {
                my($y,$m,$d,$h,$mn,$s) = Date::Manip::UnixDate($_, @a);
                my $e = Date_SecsSince1970GMT($m,$d,$y,$h,$mn,$s);
-               if( $self->{debug} )
-               {
-                       warn "Date to epochs ($_) => ($e)\n";
-               }
+               $self->debug("Date to epochs ($_) => ($e)");
                push @epochs, $e;
        }
 
@@ -528,10 +524,8 @@
                shift(@epochs) while @epochs && ( $epochs[0] <= $now);
        }
 
-       if($self->{debug})
-       {
-               warn "Recurrances are at: ".join("\n\t", @dates),"\n";
-       }
+       $self->debug("Recurrances are at: ".join("\n\t", @dates));
+
        warn "No recurrances found! Probably a timezone issue!\n" unless @dates;
 
        return @epochs;
@@ -588,15 +582,16 @@
        # Make sure we are at the EOF
        seek($self->{LDF}->{fh}, 0, 2);
 
-       warn localtime() ." $$ Locked\n" if $self->{debug};
+       $self->debug("Locked");
        return;
 }
 
 sub unlock 
 {
        my $self = shift;
+
        safe_flock($self->{LDF}->{fh},LOCK_UN);
-       warn localtime() . " $$ unLocked\n" if $self->{debug};
+       $self->debug("unLocked");
 }
 
 # Inspired by BSD's flopen(), returns filehandle on success
@@ -617,7 +612,6 @@
                }
 
                my @path_stat = stat $path;
-
                unless (@path_stat) {
                        # file disappeared fron under our feet
                        close $fh;
@@ -670,7 +664,14 @@
 
 sub debug
 {
-       $_[0]->{'debug'} = $_[1];
+       my $self = shift;
+       my ($message) = @_;
+
+       return unless($self->{debug});
+
+       warn localtime() . " $$ $message\n";
+
+       return;
 }
 
 =pod
@@ -681,14 +682,14 @@
 
 =head1 VERSION
 
-version 1.29
+version 1.30
 
 =head1 SYNOPSIS
 
   use Log::Dispatch::FileRotate;
 
   my $file = Log::Dispatch::FileRotate->new(
-      filename  => 'file1',
+      name      => 'file1',
       min_level => 'info',
       filename  => 'Somefile.log',
       mode      => 'append' ,
@@ -698,7 +699,7 @@
   # or for a time based rotation
 
   my $file = Log::Dispatch::FileRotate->new(
-      filename  => 'file1',
+      name      => 'file1',
       min_level => 'info',
       filename  => 'Somefile.log',
       mode      => 'append' ,
@@ -944,7 +945,7 @@
 
 =head1 SOURCE
 
-The development version is on github at 
L<http://github.com/mschout/perl-log-dispatch-filerotate>
+The development version is on github at 
L<https://github.com/mschout/perl-log-dispatch-filerotate>
 and may be cloned from 
L<git://github.com/mschout/perl-log-dispatch-filerotate.git>
 
 =head1 BUGS
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/Log-Dispatch-FileRotate-1.29/t/author-lockfile-race-condition.t 
new/Log-Dispatch-FileRotate-1.30/t/author-lockfile-race-condition.t
--- old/Log-Dispatch-FileRotate-1.29/t/author-lockfile-race-condition.t 
2017-07-28 17:15:44.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.30/t/author-lockfile-race-condition.t 
2017-08-03 22:33:46.000000000 +0200
@@ -53,7 +53,7 @@
 
 my $output = read_warnings($warnings_file);
 
-is $output, 'got lock:exiting:got lock:exiting:got lock:exiting';
+is $output, 'got lock:releasing lock:got lock:releasing lock:got 
lock:releasing lock';
 
 # shim a delay in before logit() so that it will wait for the child process
 # to enter the critical section
@@ -77,8 +77,9 @@
         my $msg = shift;
 
         # we only want the "got lock" and "exiting" lines
-        if ($msg =~ /got lock/ or $msg =~ /exiting/) {
-            # strip off pid numbers from front of message
+        if ($msg =~ /got lock/ or $msg =~ /releasing/) {
+            # strip off dates and pid numbers from front of message
+            $msg = substr($msg, 25);
             $msg =~ s/^[0-9]+ //;
 
             # save in the warnings file
@@ -107,8 +108,6 @@
         }
     }
 
-    warn "$$ exiting\n";
-
     delete $SIG{__WARN__};
     close $warnfh;
 }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.29/t/author-signature.t 
new/Log-Dispatch-FileRotate-1.30/t/author-signature.t
--- old/Log-Dispatch-FileRotate-1.29/t/author-signature.t       2017-07-28 
17:15:44.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.30/t/author-signature.t       2017-08-03 
22:33:46.000000000 +0200
@@ -7,6 +7,7 @@
   }
 }
 
+# This file was automatically generated by 
Dist::Zilla::Plugin::AuthorSignatureTest
 
 use strict;
 use warnings;


Reply via email to