Hello community, here is the log from the commit of package gnome-shell for openSUSE:Factory checked in at 2017-10-20 16:13:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-shell (Old) and /work/SRC/openSUSE:Factory/.gnome-shell.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-shell" Fri Oct 20 16:13:13 2017 rev:141 rq:534230 version:3.26.1 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-shell/gnome-shell.changes 2017-10-06 11:02:53.794368594 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-shell.new/gnome-shell.changes 2017-10-20 16:13:16.507001178 +0200 @@ -1,0 +2,13 @@ +Sat Oct 14 20:53:32 UTC 2017 - [email protected] + +- Add gnome-shell-osk-dont-popup-when-not-needed.patch: Stop the + on-screen keyboard from showing up when touchscreen use doesn't + activate a text field; patch taken from upstream bug report + (bgo#788188). + +------------------------------------------------------------------- +Mon Oct 9 06:25:05 UTC 2017 - [email protected] + +- Update gs-sle-classic-ext.patch to version 3.26.1 + +------------------------------------------------------------------- New: ---- gnome-shell-osk-dont-popup-when-not-needed.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-shell.spec ++++++ --- /var/tmp/diff_new_pack.4HjfUL/_old 2017-10-20 16:13:17.426958203 +0200 +++ /var/tmp/diff_new_pack.4HjfUL/_new 2017-10-20 16:13:17.426958203 +0200 @@ -39,10 +39,10 @@ Patch2: gnome-shell-disable-ibus-when-not-installed.patch # PATCH-FIX-UPSTREAM gnome-shell-Avoid-loginDialog-grab-focus-when-locked.patch bsc#1058521 bgo#788169 [email protected] -- Avoid login dialog grabs focus when screen locked Patch3: gnome-shell-Avoid-loginDialog-grab-focus-when-locked.patch +# PATCH-FIX-UPSTREAM gnome-shell-osk-dont-popup-when-not-needed.patch bgo#788188 [email protected] -- Stop the on-screen keyboard from showing up when touchscreen use doesn't activate a text field; patch taken from upstream bug report +Patch4: gnome-shell-osk-dont-popup-when-not-needed.patch ## NOTE: Keep SLE only patches at bottom (starting on 1000). -# PATCH-FEATURE-SLE gs-sle-classic-ext.patch bnc#862615 [email protected] -- add SLE Classic support -Patch1000: gs-sle-classic-ext.patch # PATCH-FEATURE-SLE gnome-shell-gdm-login-applet.patch fate#314545 [email protected] -- Add an applet on login UI to display suse icon, product name, hostname. Patch1001: gnome-shell-gdm-login-applet.patch # PATCH-FEATURE-SLE gnome-shell-domain.patch fate#307773 [email protected] -- Active Directory Integration @@ -59,6 +59,9 @@ Patch1007: gs-fate318433-prevent-same-account-multi-logins.patch # PATCH-FEATURE-SLE gnome-shell-1007468-lock-screen-SUSE-logo-missing.patch [email protected] -- Add SUSE logo on lock screen for GNOME theme. Patch1008: gnome-shell-1007468-lock-screen-SUSE-logo-missing.patch +## NOTE: Keep SLE Classic pathes at bottom. +# PATCH-FEATURE-SLE gs-sle-classic-ext.patch bnc#862615 [email protected] -- add SLE Classic support +Patch1100: gs-sle-classic-ext.patch # needed for directory ownership BuildRequires: dbus-1 @@ -186,9 +189,9 @@ #patch1 -p1 %patch2 -p1 %patch3 -p1 +%patch4 -p1 %if !0%{?is_opensuse} -%patch1000 -p1 %patch1001 -p1 %patch1002 -p1 %patch1003 -p1 @@ -197,6 +200,7 @@ %patch1006 -p1 %patch1007 -p1 %patch1008 -p1 +%patch1100 -p1 translation-update-upstream %endif cp %{SOURCE1} js/ui/ ++++++ gnome-shell-osk-dont-popup-when-not-needed.patch ++++++ >From 23d3b716c72d036ae7030fb8335acf168ea32685 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= <[email protected]> Date: Fri, 13 Oct 2017 17:46:58 +0200 Subject: [PATCH] keyboard: Minor cleanup _syncEnabled() will call _setupKeyboard() if necessary, so no need to call it explicitly before. https://bugzilla.gnome.org/show_bug.cgi?id=788188 --- js/ui/keyboard.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index da36c3615..87635ce83 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -324,10 +324,8 @@ var Keyboard = new Lang.Class({ _sync: function () { if (this._keyboard && - this._keyboard.keyboard_type != this._keyboardSettings.get_string(KEYBOARD_TYPE)) { + this._keyboard.keyboard_type != this._keyboardSettings.get_string(KEYBOARD_TYPE)) this._destroyKeyboard(); - this._setupKeyboard(); - } this._syncEnabled(); }, -- 2.14.2From f20a30e3a6b4cf305a64780295bd6483461763a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= <[email protected]> Date: Mon, 9 Oct 2017 12:51:08 +0200 Subject: [PATCH] keyboard: Split enabled setting from enabled state We enable the keyboard when it is either enabled explicitly via a11y settings or when using a touch device. We'll soon want to special-case changes to the GSettings, so track its value in a dedicated property. https://bugzilla.gnome.org/show_bug.cgi?id=788188 --- js/ui/keyboard.js | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index 87635ce83..771f23dc2 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -168,6 +168,9 @@ var Keyboard = new Lang.Class({ this._caretTrackingEnabled = false; this._updateCaretPositionId = 0; + this._enableKeyboard = false; // a11y settings value + this._enabled = false; // enabled state (by setting or device type) + this._keyboardSettings = new Gio.Settings({ schema_id: KEYBOARD_SCHEMA }); this._keyboardSettings.connect('changed', Lang.bind(this, this._sync)); this._a11yApplicationsSettings = new Gio.Settings({ schema_id: A11Y_APPLICATIONS_SCHEMA }); @@ -305,14 +308,14 @@ var Keyboard = new Lang.Class({ }, _syncEnabled: function () { - this._enableKeyboard = this._a11yApplicationsSettings.get_boolean(SHOW_KEYBOARD) || - this._lastDeviceIsTouchscreen(); - if (!this._enableKeyboard && !this._keyboard) + this._enableKeyboard = this._a11yApplicationsSettings.get_boolean(SHOW_KEYBOARD); + this._enabled = this._enableKeyboard || this._lastDeviceIsTouchscreen(); + if (!this._enabled && !this._keyboard) return; - this._setCaretTrackerEnabled(this._enableKeyboard); + this._setCaretTrackerEnabled(this._enabled); - if (this._enableKeyboard) { + if (this._enabled) { if (!this._keyboard) this._setupKeyboard(); else @@ -509,7 +512,7 @@ var Keyboard = new Lang.Class({ }, _redraw: function () { - if (!this._enableKeyboard) + if (!this._enabled) return; let monitor = Main.layoutManager.keyboardMonitor; @@ -614,7 +617,7 @@ var Keyboard = new Lang.Class({ }, show: function (monitor) { - if (!this._enableKeyboard) + if (!this._enabled) return; this._clearShowIdle(); @@ -650,7 +653,7 @@ var Keyboard = new Lang.Class({ }, hide: function () { - if (!this._enableKeyboard) + if (!this._enabled) return; this._clearShowIdle(); @@ -713,14 +716,14 @@ var Keyboard = new Lang.Class({ }, setCursorLocation: function(x, y, w, h) { - if (!this._enableKeyboard) + if (!this._enabled) return; // this._setLocation(x, y); }, setEntryLocation: function(x, y, w, h) { - if (!this._enableKeyboard) + if (!this._enabled) return; // this._setLocation(x, y); -- 2.14.2From e73a0724bbc5f9aab3ce856324a8e6e83690173c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= <[email protected]> Date: Mon, 9 Oct 2017 12:53:04 +0200 Subject: [PATCH] keyboard: Don't pop up on touch events We want touch events to enable the keyboard and focus tracking, but not to actually show it right away. Implement that behavior by only changing the visibility of the keyboard when triggered by a GSettings change. https://bugzilla.gnome.org/show_bug.cgi?id=788188 --- js/ui/keyboard.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index 771f23dc2..9f1cb56c6 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -308,6 +308,7 @@ var Keyboard = new Lang.Class({ }, _syncEnabled: function () { + let wasEnabled = this._enableKeyboard; this._enableKeyboard = this._a11yApplicationsSettings.get_boolean(SHOW_KEYBOARD); this._enabled = this._enableKeyboard || this._lastDeviceIsTouchscreen(); if (!this._enabled && !this._keyboard) @@ -315,14 +316,15 @@ var Keyboard = new Lang.Class({ this._setCaretTrackerEnabled(this._enabled); - if (this._enabled) { - if (!this._keyboard) - this._setupKeyboard(); - else - Main.layoutManager.showKeyboard(); - } else { + if (this._enabled && !this._keyboard) { + this._setupKeyboard(); Main.layoutManager.hideKeyboard(true); } + + if (this._enableKeyboard && !wasEnabled) + Main.layoutManager.showKeyboard(); + else if (!this._enableKeyboard && wasEnabled) + Main.layoutManager.hideKeyboard(true); }, _sync: function () { -- 2.14.2++++++ gs-sle-classic-ext.patch ++++++ --- /var/tmp/diff_new_pack.4HjfUL/_old 2017-10-20 16:13:17.534953158 +0200 +++ /var/tmp/diff_new_pack.4HjfUL/_new 2017-10-20 16:13:17.534953158 +0200 @@ -1,8 +1,8 @@ -Index: gnome-shell-3.25.91/js/js-resources.gresource.xml +Index: gnome-shell-3.26.1/js/js-resources.gresource.xml =================================================================== ---- gnome-shell-3.25.91.orig/js/js-resources.gresource.xml -+++ gnome-shell-3.25.91/js/js-resources.gresource.xml -@@ -111,6 +111,7 @@ +--- gnome-shell-3.26.1.orig/js/js-resources.gresource.xml ++++ gnome-shell-3.26.1/js/js-resources.gresource.xml +@@ -109,6 +109,7 @@ <file>ui/workspaceThumbnail.js</file> <file>ui/workspacesView.js</file> <file>ui/xdndHandler.js</file> @@ -10,10 +10,10 @@ <file>ui/components/__init__.js</file> <file>ui/components/autorunManager.js</file> -Index: gnome-shell-3.25.91/js/ui/layout.js +Index: gnome-shell-3.26.1/js/ui/layout.js =================================================================== ---- gnome-shell-3.25.91.orig/js/ui/layout.js -+++ gnome-shell-3.25.91/js/ui/layout.js +--- gnome-shell-3.26.1.orig/js/ui/layout.js ++++ gnome-shell-3.26.1/js/ui/layout.js @@ -25,6 +25,8 @@ var BACKGROUND_FADE_ANIMATION_TIME = 1.0 var HOT_CORNER_PRESSURE_THRESHOLD = 100; // pixels var HOT_CORNER_PRESSURE_TIMEOUT = 1000; // ms @@ -23,19 +23,19 @@ function isPopupMetaWindow(actor) { switch(actor.meta_window.get_window_type()) { case Meta.WindowType.DROPDOWN_MENU: -@@ -458,7 +460,7 @@ var LayoutManager = new Lang.Class({ - this.screenShieldGroup.set_position(0, 0); - this.screenShieldGroup.set_size(global.screen_width, global.screen_height); +@@ -474,7 +476,7 @@ var LayoutManager = new Lang.Class({ + if (!this.primaryMonitor) + return; - this.panelBox.set_position(this.primaryMonitor.x, this.primaryMonitor.y); + SLEClassicExt.setMainPanelPosition(this.panelBox, this.primaryMonitor); this.panelBox.set_size(this.primaryMonitor.width, -1); this.keyboardIndex = this.primaryIndex; -Index: gnome-shell-3.25.91/js/ui/main.js +Index: gnome-shell-3.26.1/js/ui/main.js =================================================================== ---- gnome-shell-3.25.91.orig/js/ui/main.js -+++ gnome-shell-3.25.91/js/ui/main.js +--- gnome-shell-3.26.1.orig/js/ui/main.js ++++ gnome-shell-3.26.1/js/ui/main.js @@ -45,6 +45,8 @@ const Magnifier = imports.ui.magnifier; const XdndHandler = imports.ui.xdndHandler; const Util = imports.misc.util; @@ -45,7 +45,7 @@ const A11Y_SCHEMA = 'org.gnome.desktop.a11y.keyboard'; const STICKY_KEYS_ENABLE = 'stickykeys-enable'; const GNOMESHELL_STARTED_MESSAGE_ID = 'f3ea493c22934e26811cd62abe8e203a'; -@@ -130,6 +132,8 @@ function start() { +@@ -131,6 +133,8 @@ function start() { shellMountOpDBusService = new ShellMountOperation.GnomeShellMountOpHandler(); _sessionUpdated(); @@ -54,10 +54,10 @@ } function _initializeUI() { -Index: gnome-shell-3.25.91/js/ui/panel.js +Index: gnome-shell-3.26.1/js/ui/panel.js =================================================================== ---- gnome-shell-3.25.91.orig/js/ui/panel.js -+++ gnome-shell-3.25.91/js/ui/panel.js +--- gnome-shell-3.26.1.orig/js/ui/panel.js ++++ gnome-shell-3.26.1/js/ui/panel.js @@ -25,6 +25,8 @@ const RemoteMenu = imports.ui.remoteMenu const Main = imports.ui.main; const Tweener = imports.ui.tweener; @@ -67,7 +67,7 @@ var PANEL_ICON_SIZE = 16; var APP_MENU_ICON_MARGIN = 0; -@@ -850,7 +852,9 @@ var Panel = new Lang.Class({ +@@ -855,7 +857,9 @@ var Panel = new Lang.Class({ alloc.natural_size = -1; }, @@ -78,10 +78,10 @@ let allocWidth = box.x2 - box.x1; let allocHeight = box.y2 - box.y1; -Index: gnome-shell-3.25.91/js/ui/sessionMode.js +Index: gnome-shell-3.26.1/js/ui/sessionMode.js =================================================================== ---- gnome-shell-3.25.91.orig/js/ui/sessionMode.js -+++ gnome-shell-3.25.91/js/ui/sessionMode.js +--- gnome-shell-3.26.1.orig/js/ui/sessionMode.js ++++ gnome-shell-3.26.1/js/ui/sessionMode.js @@ -13,6 +13,8 @@ const Config = imports.misc.config; const DEFAULT_MODE = 'restrictive';
