Hello community, here is the log from the commit of package gnome-music for openSUSE:Factory checked in at 2018-05-10 15:47:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-music (Old) and /work/SRC/openSUSE:Factory/.gnome-music.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-music" Thu May 10 15:47:28 2018 rev:38 rq:605379 version:3.28.2.1 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-music/gnome-music.changes 2018-04-19 15:23:07.838573041 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-music.new/gnome-music.changes 2018-05-10 15:47:30.653417889 +0200 @@ -1,0 +2,14 @@ +Mon May 7 22:46:34 UTC 2018 - [email protected] + +- Update to version 3.28.2.1: + + baseview: Do not reset init state. +- Changes from version 3.28.2: + + Fix notification calls on startup. + + artistalbumswidget: Wait for last album to load + (glgo#GNOME/gnome-music#174). + + grilo: Fix audio check. + + Updated translations. +- Drop update-desktop-files BuildRequires and suse_update_desktop_\ + file: they are no longer required. + +------------------------------------------------------------------- @@ -5 +19,2 @@ - + Fix issue with untranslated UI elements (glgo#gnome-music#169). + + Fix issue with untranslated UI elements + (glgo#GNOME/gnome-music#169). Old: ---- gnome-music-3.28.1.tar.xz New: ---- gnome-music-3.28.2.1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-music.spec ++++++ --- /var/tmp/diff_new_pack.KgP8Xh/_old 2018-05-10 15:47:31.401390475 +0200 +++ /var/tmp/diff_new_pack.KgP8Xh/_new 2018-05-10 15:47:31.405390329 +0200 @@ -17,7 +17,7 @@ Name: gnome-music -Version: 3.28.1 +Version: 3.28.2.1 Release: 0 Summary: Music Player for GNOME License: SUSE-GPL-2.0-with-plugin-exception AND LGPL-2.1-or-later @@ -30,7 +30,6 @@ BuildRequires: meson BuildRequires: pkgconfig BuildRequires: python3-devel >= 3.3 -BuildRequires: update-desktop-files BuildRequires: pkgconfig(glib-2.0) >= 2.36.0 BuildRequires: pkgconfig(gnome-desktop-3.0) BuildRequires: pkgconfig(gobject-introspection-1.0) >= 1.35.9 @@ -73,7 +72,6 @@ %install %meson_install -%suse_update_desktop_file org.gnome.Music %find_lang %{name} %{?no_lang_C} %find_lang org.gnome.Music %{?no_lang_C} %{name}.lang %fdupes %{buildroot}%{python3_sitelib}/gnomemusic ++++++ gnome-music-3.28.1.tar.xz -> gnome-music-3.28.2.1.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/NEWS new/gnome-music-3.28.2.1/NEWS --- old/gnome-music-3.28.1/NEWS 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/NEWS 2018-05-08 08:11:51.000000000 +0200 @@ -1,3 +1,36 @@ +Overview of changes in 3.28.2 +============================= + +Bugs fixed: + Fix notification calls on startupt (!147) + artistalbumswidget: Wait for last album to load (#174) + grilo: Fix audio check (!159) + +Thanks to our contributors this release: + Alexander Mikhaylenko + Jean Felder + Marinus Schraal + +Overview of changes in 3.28.1 +============================= + +Bugs fixed: + Minor optimizations (!138) + flatpak: Enable MPRIS and GNOME media keys (!129) + notificationspopup: Fix source not found warning (!131) + Ellipsized songs in Artists View are improperly aligned (#173) + albumwidget: Restore currently played album (#111) + +Thanks to our contributors this release: + Alexander Mikhaylenko + Georges Basile Stavracas Neto + Jean Felder + Marinus Schraal + +Translations updated: + Romanian + Slovenian + Overview of changes in 3.28.0.1 =============================== diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/data/AboutDialog.ui.in new/gnome-music-3.28.2.1/data/AboutDialog.ui.in --- old/gnome-music-3.28.1/data/AboutDialog.ui.in 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/data/AboutDialog.ui.in 2018-05-08 08:11:51.000000000 +0200 @@ -22,6 +22,7 @@ </property> <property name="authors">Abhinav Singh Alberto Fanjul +Alexander Mikhaylenko Andreas Nilsson Arnel A. Borja Benoît Legat @@ -74,6 +75,7 @@ </property> <property name="translator_credits">Alain Lojewski Alan Mortensen +Alexander Mikhaylenko Alexandre Franke Anders Jonsson Andika Triwidada diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/gnomemusic/grilo.py new/gnome-music-3.28.2.1/gnomemusic/grilo.py --- old/gnome-music-3.28.1/gnomemusic/grilo.py 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/gnomemusic/grilo.py 2018-05-08 08:11:51.000000000 +0200 @@ -137,14 +137,9 @@ with self.tracker.handler_block(self.notification_handler): for media in changedMedias: media_id = media.get_id() - if changeType == Grl.SourceChangeType.ADDED: - # Check that this media is an audio file - mime_type = self.tracker.query_sync( - Query.is_audio(media_id), - [Grl.METADATA_KEY_MIME], - self.options)[0].get_mime() - if mime_type and mime_type.startswith("audio"): - self.changed_media_ids.append(media_id) + if (changeType == Grl.SourceChangeType.ADDED + and media.is_audio()): + self.changed_media_ids.append(media_id) if changeType == Grl.SourceChangeType.REMOVED: # There is no way to check that removed item is a media # so always do the refresh diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/gnomemusic/query.py new/gnome-music-3.28.2.1/gnomemusic/query.py --- old/gnome-music-3.28.1/gnomemusic/query.py 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/gnomemusic/query.py 2018-05-08 08:11:51.000000000 +0200 @@ -1024,19 +1024,3 @@ } return query - - @staticmethod - def is_audio(media_id): - query = """ - SELECT DISTINCT - rdf:type - nie:mimeType(?urn) AS mime_type - { - ?urn rdf:type nie:InformationElement . - FILTER ( tracker:id(?urn) = "%(media_id)s" ) - } - """.replace('\n', '').strip() % { - 'media_id': media_id - } - - return query diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/gnomemusic/views/albumsview.py new/gnome-music-3.28.2.1/gnomemusic/views/albumsview.py --- old/gnome-music-3.28.1/gnomemusic/views/albumsview.py 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/gnomemusic/views/albumsview.py 2018-05-08 08:11:51.000000000 +0200 @@ -61,7 +61,6 @@ def _on_changes_pending(self, data=None): if (self._init and not self._header_bar.selection_mode): self._offset = 0 - self._init = True GLib.idle_add(self.populate) grilo.changes_pending['Albums'] = False @@ -166,6 +165,7 @@ priority=GLib.PRIORITY_LOW) self._window.notifications_popup.pop_loading() + self._init = False def _create_album_item(self, item): artist = utils.get_artist_name(item) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/gnomemusic/views/baseview.py new/gnome-music-3.28.2.1/gnomemusic/views/baseview.py --- old/gnome-music-3.28.1/gnomemusic/views/baseview.py 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/gnomemusic/views/baseview.py 2018-05-08 08:11:51.000000000 +0200 @@ -194,7 +194,6 @@ @log def _populate(self, data=None): - self._init = True self.populate() @log diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/gnomemusic/views/playlistview.py new/gnome-music-3.28.2.1/gnomemusic/views/playlistview.py --- old/gnome-music-3.28.1/gnomemusic/views/playlistview.py 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/gnomemusic/views/playlistview.py 2018-05-08 08:11:51.000000000 +0200 @@ -257,12 +257,6 @@ cell.set_visible(False) @log - def _populate(self): - self._init = True - self._window.notifications_popup.push_loading() - self.populate() - - @log def _update_model(self, player, playlist, current_iter): if self._iter_to_clean: self._iter_to_clean_model[self._iter_to_clean][10] = False @@ -821,4 +815,5 @@ """Populate sidebar. Do not reload playlists already displayed. """ + self._window.notifications_popup.push_loading() grilo.populate_playlists(self._offset, self._add_playlist_item) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/gnomemusic/views/searchview.py new/gnome-music-3.28.2.1/gnomemusic/views/searchview.py --- old/gnome-music-3.28.1/gnomemusic/views/searchview.py 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/gnomemusic/views/searchview.py 2018-05-08 08:11:51.000000000 +0200 @@ -346,7 +346,6 @@ @log def populate(self): self._init = True - self._window.notifications_popup.push_loading() self._header_bar.set_state(ToolbarState.MAIN) @log @@ -530,6 +529,7 @@ or grilo.search_source.get_id() == 'grl-tracker-source'): for category in ('album', 'artist', 'song'): query = query_matcher[category][fields_filter](search_term) + self._window.notifications_popup.push_loading() grilo.populate_custom_query( query, self._add_item, -1, [self.model, category]) if (not grilo.search_source diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/gnomemusic/widgets/artistalbumswidget.py new/gnome-music-3.28.2.1/gnomemusic/widgets/artistalbumswidget.py --- old/gnome-music-3.28.1/gnomemusic/widgets/artistalbumswidget.py 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/gnomemusic/widgets/artistalbumswidget.py 2018-05-08 08:11:51.000000000 +0200 @@ -86,11 +86,9 @@ self._window.notifications_popup.push_loading() + self._albums_to_load = len(albums) for album in albums: - is_last_album = False - if album == albums[-1]: - is_last_album = True - self._add_album(album, is_last_album) + self._add_album(album) self._player.connect('playlist-item-changed', self._update_model) @@ -113,12 +111,14 @@ ) @log - def _on_last_album_displayed(self, data=None): - self._window.notifications_popup.pop_loading() - self.show_all() + def _on_album_displayed(self, data=None): + self._albums_to_load -= 1 + if self._albums_to_load == 0: + self._window.notifications_popup.pop_loading() + self.show_all() @log - def _add_album(self, album, is_last_album=False): + def _add_album(self, album): widget = ArtistAlbumWidget(album, self._player, self._model, self._header_bar, self._selection_mode_allowed, @@ -129,8 +129,7 @@ self._album_box.pack_start(widget, False, False, 0) self._widgets.append(widget) - if is_last_album: - widget.connect('songs-loaded', self._on_last_album_displayed) + widget.connect('songs-loaded', self._on_album_displayed) @log def _update_model(self, player, playlist, current_iter): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.28.1/meson.build new/gnome-music-3.28.2.1/meson.build --- old/gnome-music-3.28.1/meson.build 2018-04-09 23:14:18.000000000 +0200 +++ new/gnome-music-3.28.2.1/meson.build 2018-05-08 08:11:51.000000000 +0200 @@ -1,5 +1,5 @@ project('gnome-music', - version: '3.28.0.1' + version: '3.28.2' ) # Importing modules
