Hello community,

here is the log from the commit of package claws-mail for openSUSE:Factory 
checked in at 2018-05-29 10:28:23
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/claws-mail (Old)
 and      /work/SRC/openSUSE:Factory/.claws-mail.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "claws-mail"

Tue May 29 10:28:23 2018 rev:80 rq:609847 version:3.16.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/claws-mail/claws-mail.changes    2018-01-17 
21:56:09.401269056 +0100
+++ /work/SRC/openSUSE:Factory/.claws-mail.new/claws-mail.changes       
2018-05-29 10:28:26.149011804 +0200
@@ -26,0 +27,6 @@
+Mon Oct  9 12:23:55 UTC 2017 - msucha...@suse.com
+
+- Fix Reply to all replying to random people
+  + Do-not-use-msginfo_list-for-compose.patch
+
+-------------------------------------------------------------------

New:
----
  Do-not-use-msginfo_list-for-compose.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ claws-mail.spec ++++++
--- /var/tmp/diff_new_pack.vWqmWs/_old  2018-05-29 10:28:27.276970130 +0200
+++ /var/tmp/diff_new_pack.vWqmWs/_new  2018-05-29 10:28:27.280969982 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package claws-mail
 #
-# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -33,10 +33,11 @@
 Release:        0
 URL:            http://www.claws-mail.org/
 Summary:        A configurable email client
-License:        GPL-3.0+
+License:        GPL-3.0-or-later
 Group:          Productivity/Networking/Email/Clients
 Source:         
http://www.claws-mail.org/download.php?file=releases/%{name}-%{version}.tar.xz
 Patch:          libcanberra-gtk3.patch
+Patch2:         Do-not-use-msginfo_list-for-compose.patch
 BuildRequires:  NetworkManager-devel
 BuildRequires:  compface-devel
 BuildRequires:  db-devel
@@ -104,7 +105,7 @@
 
 %package devel
 Summary:        Development files for claws-mail
-License:        GPL-2.0+
+License:        GPL-2.0-or-later
 Group:          Development/Libraries/C and C++
 Provides:       claws-mail:/usr/include/claws-mail/main.h
 # The extra-plugin package was merged with version 3.9.1; as such, also the 
-devel package merged
@@ -132,6 +133,7 @@
 %if ! 0%{?favor_gtk2}
 %patch -p1
 %endif
+%patch2 -p1
 sed -i 's/#!\/usr\/bin\/env python/#!\/usr\/bin\/python/' tools/*.py
 sed -i 's/#!\/usr\/bin\/env bash/#!\/bin\/bash/' tools/*.sh
 sed -i 's/#!\/usr\/bin\/env bash/#!\/bin\/bash/' 
tools/kdeservicemenu/install.sh

++++++ Do-not-use-msginfo_list-for-compose.patch ++++++
>From f95bd79b9abd7158cd1c03bd85ea5863196625e4 Mon Sep 17 00:00:00 2001
From: Michal Suchanek <hramr...@gmail.com>
Date: Mon, 9 Oct 2017 10:15:44 +0200
Subject: [PATCH] When composing body is always taken from message view so do
 not pretend reply to mesages from summary is possible.

The only code to convert a msginfo to message text is in
messageview_show. The msginfo_list passed to
compose_reply_from_messageview serves no purpose since the repl;y body
is always taken from the messageview. In order to be able to reply to
massages from summary view and notifications compose_reply_from_msginfo
is needed.
---
 src/mainwindow.c | 2 +-
 src/toolbar.c    | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/mainwindow.c b/src/mainwindow.c
index 3d58e7cc9..07d0b331b 100644
--- a/src/mainwindow.c
+++ b/src/mainwindow.c
@@ -4129,7 +4129,7 @@ static void main_window_reply_cb(GtkAction *gaction, 
gpointer data)
 
        cm_return_if_fail(msgview != NULL);
 
-       msginfo_list = summary_get_selection(mainwin->summaryview);
+       msginfo_list = g_slist_append(msginfo_list, msgview->msginfo);
        cm_return_if_fail(msginfo_list != NULL);
        compose_reply_from_messageview(msgview, msginfo_list, action);
        g_slist_free(msginfo_list);
diff --git a/src/toolbar.c b/src/toolbar.c
index 36263293d..002cfb9bb 100644
--- a/src/toolbar.c
+++ b/src/toolbar.c
@@ -2960,19 +2960,17 @@ static void toolbar_reply(gpointer data, guint action)
        switch (toolbar_item->type) {
        case TOOLBAR_MAIN:
                mainwin = (MainWindow*)toolbar_item->parent;
-               msginfo_list = summary_get_selection(mainwin->summaryview);
                msgview = (MessageView*)mainwin->messageview;
                break;
        case TOOLBAR_MSGVIEW:
                msgview = (MessageView*)toolbar_item->parent;
-               cm_return_if_fail(msgview != NULL);     
-               msginfo_list = g_slist_append(msginfo_list, msgview->msginfo);
                break;
        default:
                return;
        }
 
        cm_return_if_fail(msgview != NULL);
+       msginfo_list = g_slist_append(msginfo_list, msgview->msginfo);
        cm_return_if_fail(msginfo_list != NULL);
        compose_reply_from_messageview(msgview, msginfo_list, action);
        g_slist_free(msginfo_list);
-- 
2.11.0


Reply via email to