Hello community, here is the log from the commit of package openQA for openSUSE:Factory checked in at 2018-06-04 13:22:32 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/openQA (Old) and /work/SRC/openSUSE:Factory/.openQA.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "openQA" Mon Jun 4 13:22:32 2018 rev:24 rq:613831 version:4.5.1528009330.e68ebe2b Changes: -------- --- /work/SRC/openSUSE:Factory/openQA/openQA.changes 2018-06-02 12:13:00.486097661 +0200 +++ /work/SRC/openSUSE:Factory/.openQA.new/openQA.changes 2018-06-04 13:23:27.238590615 +0200 @@ -1,0 +2,6 @@ +Mon Jun 04 00:19:38 UTC 2018 - [email protected] + +- Update to version 4.5.1528009330.e68ebe2b: + * Remove uncovered as unused asset_list call (#1675) + +------------------------------------------------------------------- Old: ---- openQA-4.5.1527697506.2eedfb2e.tar.xz New: ---- openQA-4.5.1528009330.e68ebe2b.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ openQA.spec ++++++ --- /var/tmp/diff_new_pack.EnSB56/_old 2018-06-04 13:23:28.106558831 +0200 +++ /var/tmp/diff_new_pack.EnSB56/_new 2018-06-04 13:23:28.110558685 +0200 @@ -36,7 +36,7 @@ # runtime requirements that also the testsuite needs %define t_requires perl(DBD::Pg) perl(DBIx::Class) perl(Config::IniFiles) perl(SQL::Translator) perl(Date::Format) perl(File::Copy::Recursive) perl(DateTime::Format::Pg) perl(Net::OpenID::Consumer) perl(Mojolicious::Plugin::RenderFile) perl(Mojolicious::Plugin::AssetPack) perl(aliased) perl(Config::Tiny) perl(DBIx::Class::DynamicDefault) perl(DBIx::Class::Schema::Config) perl(DBIx::Class::Storage::Statistics) perl(IO::Socket::SSL) perl(Data::Dump) perl(DBIx::Class::OptimisticLocking) perl(Text::Markdown) perl(Net::DBus) perl(IPC::Run) perl(Archive::Extract) perl(CSS::Minifier::XS) perl(JavaScript::Minifier::XS) perl(Time::ParseDate) perl(Sort::Versions) perl(Mojo::RabbitMQ::Client) perl(BSD::Resource) perl(Cpanel::JSON::XS) perl(Pod::POM) perl(Mojo::IOLoop::ReadWriteProcess) perl(Minion) perl(Mojo::Pg) Name: openQA -Version: 4.5.1527697506.2eedfb2e +Version: 4.5.1528009330.e68ebe2b Release: 0 Summary: The openQA web-frontend, scheduler and tools License: GPL-2.0+ ++++++ openQA-4.5.1527697506.2eedfb2e.tar.xz -> openQA-4.5.1528009330.e68ebe2b.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-4.5.1527697506.2eedfb2e/lib/OpenQA/Resource/Jobs.pm new/openQA-4.5.1528009330.e68ebe2b/lib/OpenQA/Resource/Jobs.pm --- old/openQA-4.5.1527697506.2eedfb2e/lib/OpenQA/Resource/Jobs.pm 2018-05-30 18:25:06.000000000 +0200 +++ new/openQA-4.5.1528009330.e68ebe2b/lib/OpenQA/Resource/Jobs.pm 2018-06-03 09:02:10.000000000 +0200 @@ -131,26 +131,4 @@ return @duplicated; } -# -# Assets API -# - -sub asset_list { - my %args = @_; - - my %cond; - my %attrs; - - if ($args{limit}) { - $attrs{rows} = $args{limit}; - } - $attrs{page} = $args{page} || 0; - - if ($args{type}) { - $cond{type} = $args{type}; - } - - return schema->resultset("Assets")->search(\%cond, \%attrs); -} - 1; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-4.5.1527697506.2eedfb2e/lib/OpenQA/ResourceAllocator.pm new/openQA-4.5.1528009330.e68ebe2b/lib/OpenQA/ResourceAllocator.pm --- old/openQA-4.5.1527697506.2eedfb2e/lib/OpenQA/ResourceAllocator.pm 2018-05-30 18:25:06.000000000 +0200 +++ new/openQA-4.5.1528009330.e68ebe2b/lib/OpenQA/ResourceAllocator.pm 2018-06-03 09:02:10.000000000 +0200 @@ -80,17 +80,6 @@ } - -## Assets -dbus_method('asset_list', [['dict', 'string', 'string']], [['array', ['dict', 'string', 'string']]]); -sub asset_list { - my ($self, $args) = @_; - my $rs = safe_call 'OpenQA::Resource::Jobs' => asset_list => %$args; - return [] if @$rs == 0; - @$rs[0]->result_class('DBIx::Class::ResultClass::HashRefInflator'); - return [@$rs[0]->all]; -} - dbus_method('job_restart', [['array', 'uint32']], [['array', 'uint32']]); sub job_restart { my ($self, $args) = @_; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-4.5.1527697506.2eedfb2e/t/04-scheduler.t new/openQA-4.5.1528009330.e68ebe2b/t/04-scheduler.t --- old/openQA-4.5.1527697506.2eedfb2e/t/04-scheduler.t 2018-05-30 18:25:06.000000000 +0200 +++ new/openQA-4.5.1528009330.e68ebe2b/t/04-scheduler.t 2018-06-03 09:02:10.000000000 +0200 @@ -419,22 +419,6 @@ $current_jobs = list_jobs(); is_deeply($current_jobs, [], "no jobs listed"); -my $rs = OpenQA::Resource::Jobs::asset_list(); -$rs->result_class('DBIx::Class::ResultClass::HashRefInflator'); -is_deeply( - nots($rs->all()), - { - id => 1, - name => "whatever.iso", - type => "iso", - size => undef, - checksum => undef, - last_use_job_id => undef, - fixed => 0, - }, - "asset list" -); - my $asset = $schema->resultset('Assets')->register('iso', $settings{ISO}); is($asset->name, $settings{ISO}, "asset register returns same");
