Hello community, here is the log from the commit of package xfwm4 for openSUSE:Factory checked in at 2020-08-05 20:29:48 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/xfwm4 (Old) and /work/SRC/openSUSE:Factory/.xfwm4.new.3592 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "xfwm4" Wed Aug 5 20:29:48 2020 rev:62 rq:824503 version:4.14.4 Changes: -------- --- /work/SRC/openSUSE:Factory/xfwm4/xfwm4.changes 2020-07-29 17:23:45.152728302 +0200 +++ /work/SRC/openSUSE:Factory/.xfwm4.new.3592/xfwm4.changes 2020-08-05 20:29:56.379115543 +0200 @@ -1,0 +2,7 @@ +Sat Aug 1 14:48:08 UTC 2020 - Marcel Kuehlhorn <[email protected]> + +- Update to version 4.14.4 + * Fix a crash on FreeBSD (gxo#xfce/xfwm4#411) + * Fix compilation warning due to g_type_class_add_private deprecation + +------------------------------------------------------------------- Old: ---- xfwm4-4.14.3.tar.bz2 New: ---- xfwm4-4.14.4.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ xfwm4.spec ++++++ --- /var/tmp/diff_new_pack.HMEAda/_old 2020-08-05 20:29:57.247115996 +0200 +++ /var/tmp/diff_new_pack.HMEAda/_new 2020-08-05 20:29:57.247115996 +0200 @@ -18,7 +18,7 @@ %bcond_with git Name: xfwm4 -Version: 4.14.3 +Version: 4.14.4 Release: 0 Summary: Default Window Manager for the Xfce Desktop Environment License: GPL-2.0-or-later ++++++ xfwm4-4.14.3.tar.bz2 -> xfwm4-4.14.4.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.3/ChangeLog new/xfwm4-4.14.4/ChangeLog --- old/xfwm4-4.14.3/ChangeLog 2020-07-26 09:24:13.000000000 +0200 +++ new/xfwm4-4.14.4/ChangeLog 2020-08-01 16:18:57.000000000 +0200 @@ -1,3 +1,41 @@ +commit c8588b3ec356e17f537ed47b38aa8071743dc63b +Author: Olivier Fourdan <[email protected]> +Date: Sat Aug 1 15:38:58 2020 +0200 + + Release 4.14.4! + + Signed-off-by: Olivier Fourdan <[email protected]> + +commit 9b33ef163dda0a8affcfe361791c6ad8e56bee1a +Author: Olivier Duchateau <[email protected]> +Date: Sun Jul 26 17:06:07 2020 +0200 + + Fix g_type_class_add_private deprecation + + (cherry picked from commit d3e2c246cd004cde91d5aad7d1fef5b942882596) + +commit f491c5f88bfe8c25f496389f9d411fe056649d27 +Author: Olivier Fourdan <[email protected]> +Date: Mon Jul 27 21:01:48 2020 +0200 + + clients: Fix a crash on FreeBSD + + A pid is not necessarily a long on all systems, so casting the value of + NET_WM_PID directly into a GPid may cause a stack overflow. + + Fixes: 49c1a33a + Closes: https://gitlab.xfce.org/xfce/xfwm4/-/issues/411 + Signed-off-by: Olivier Fourdan <[email protected]> + (cherry picked from commit a691e6c50ce2d797183c98bc2e9c72b8bb2b2a5a) + +commit a988a64ea84916f3e1ea649f51e8eb975f2a1456 +Author: Olivier Fourdan <[email protected]> +Date: Sun Jul 26 09:27:45 2020 +0200 + + Post release tag bump + + Signed-off-by: Olivier Fourdan <[email protected]> + commit 9283b709b51746cc39a81a9e80d9a0449bf8b981 Author: Olivier Fourdan <[email protected]> Date: Sun Jul 26 09:15:01 2020 +0200 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.3/NEWS new/xfwm4-4.14.4/NEWS --- old/xfwm4-4.14.3/NEWS 2020-07-26 09:12:48.000000000 +0200 +++ new/xfwm4-4.14.4/NEWS 2020-08-01 16:18:43.000000000 +0200 @@ -1,3 +1,9 @@ +4.14.4 +====== + +- Fix a crash on FreeBSD (xfce/xfwm4#411) +- Fix compilation warning due to g_type_class_add_private deprecation + 4.14.3 ====== diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.3/configure new/xfwm4-4.14.4/configure --- old/xfwm4-4.14.3/configure 2020-07-26 09:24:08.000000000 +0200 +++ new/xfwm4-4.14.4/configure 2020-08-01 16:18:52.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for xfwm4 4.14.3. +# Generated by GNU Autoconf 2.69 for xfwm4 4.14.4. # # Report bugs to <[email protected]>. # @@ -595,8 +595,8 @@ # Identity of this package. PACKAGE_NAME='xfwm4' PACKAGE_TARNAME='xfwm4' -PACKAGE_VERSION='4.14.3' -PACKAGE_STRING='xfwm4 4.14.3' +PACKAGE_VERSION='4.14.4' +PACKAGE_STRING='xfwm4 4.14.4' PACKAGE_BUGREPORT='[email protected]' PACKAGE_URL='' @@ -1465,7 +1465,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures xfwm4 4.14.3 to adapt to many kinds of systems. +\`configure' configures xfwm4 4.14.4 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1539,7 +1539,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of xfwm4 4.14.3:";; + short | recursive ) echo "Configuration of xfwm4 4.14.4:";; esac cat <<\_ACEOF @@ -1701,7 +1701,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -xfwm4 configure 4.14.3 +xfwm4 configure 4.14.4 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -2075,7 +2075,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by xfwm4 $as_me 4.14.3, which was +It was created by xfwm4 $as_me 4.14.4, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2938,7 +2938,7 @@ # Define the identity of the package. PACKAGE='xfwm4' - VERSION='4.14.3' + VERSION='4.14.4' cat >>confdefs.h <<_ACEOF @@ -18705,8 +18705,8 @@ REVISION=unknown -if test x"9283b709b" != x""; then - REVISION=9283b709b +if test x"c8588b3ec" != x""; then + REVISION=c8588b3ec fi cat >>confdefs.h <<_ACEOF @@ -19271,7 +19271,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by xfwm4 $as_me 4.14.3, which was +This file was extended by xfwm4 $as_me 4.14.4, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -19337,7 +19337,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -xfwm4 config.status 4.14.3 +xfwm4 config.status 4.14.4 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.3/configure.ac new/xfwm4-4.14.4/configure.ac --- old/xfwm4-4.14.3/configure.ac 2020-07-26 09:24:04.000000000 +0200 +++ new/xfwm4-4.14.4/configure.ac 2020-08-01 16:18:48.000000000 +0200 @@ -10,8 +10,8 @@ m4_define([xfwm4_version_major], [4]) m4_define([xfwm4_version_minor], [14]) -m4_define([xfwm4_version_micro], [3]) -m4_define([xfwm4_version_build], [9283b709b]) +m4_define([xfwm4_version_micro], [4]) +m4_define([xfwm4_version_build], [c8588b3ec]) m4_define([xfwm4_version_tag], []) m4_define([xfwm4_version], [xfwm4_version_major().xfwm4_version_minor().xfwm4_version_micro()ifelse(xfwm4_version_tag(), [git], [xfwm4_version_tag().xfwm4_version_build()], [xfwm4_version_tag()])]) @@ -296,8 +296,8 @@ XDT_FEATURE_DEBUG REVISION=unknown -if test x"9283b709b" != x""; then - REVISION=9283b709b +if test x"c8588b3ec" != x""; then + REVISION=c8588b3ec fi AC_DEFINE_UNQUOTED([REVISION], "$REVISION", [git id]) AC_SUBST([REVISION]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.3/settings-dialogs/xfwm4-settings.c new/xfwm4-4.14.4/settings-dialogs/xfwm4-settings.c --- old/xfwm4-4.14.3/settings-dialogs/xfwm4-settings.c 2020-04-11 17:46:02.000000000 +0200 +++ new/xfwm4-4.14.4/settings-dialogs/xfwm4-settings.c 2020-08-01 15:29:03.000000000 +0200 @@ -63,12 +63,6 @@ -#define XFWM_SETTINGS_GET_PRIVATE(obj) (G_TYPE_INSTANCE_GET_PRIVATE ((obj), \ - XFWM_TYPE_SETTINGS, \ - XfwmSettingsPrivate)) - - - typedef struct _MenuTemplate MenuTemplate; @@ -82,10 +76,8 @@ -static void xfwm_settings_class_init (XfwmSettingsClass *klass, - gpointer data); -static void xfwm_settings_init (XfwmSettings *settings, - gpointer data); +static void xfwm_settings_class_init (XfwmSettingsClass *klass); +static void xfwm_settings_init (XfwmSettings *settings); static void xfwm_settings_constructed (GObject *object); static void xfwm_settings_finalize (GObject *object); static void xfwm_settings_get_property (GObject *object, @@ -221,7 +213,7 @@ -static GObjectClass *xfwm_settings_parent_class = NULL; +G_DEFINE_TYPE_WITH_PRIVATE (XfwmSettings, xfwm_settings, G_TYPE_OBJECT) static const MenuTemplate double_click_values[] = { { N_("Shade window"), "shade" }, @@ -252,45 +244,12 @@ }; -GType -xfwm_settings_get_type (void) -{ - static GType type = G_TYPE_INVALID; - - if (G_UNLIKELY (type == G_TYPE_INVALID)) - { - static const GTypeInfo info = - { - sizeof (XfwmSettingsClass), - NULL, - NULL, - (GClassInitFunc) xfwm_settings_class_init, - NULL, - NULL, - sizeof (XfwmSettings), - 0, - (GInstanceInitFunc) xfwm_settings_init, - NULL, - }; - - type = g_type_register_static (G_TYPE_OBJECT, "XfwmSettings", &info, 0); - } - - return type; -} - - static void -xfwm_settings_class_init (XfwmSettingsClass *klass, gpointer data) +xfwm_settings_class_init (XfwmSettingsClass *klass) { GObjectClass *gobject_class; - g_type_class_add_private (klass, sizeof (XfwmSettingsPrivate)); - - /* Determine the parent type class */ - xfwm_settings_parent_class = g_type_class_peek_parent (klass); - gobject_class = G_OBJECT_CLASS (klass); gobject_class->constructed = xfwm_settings_constructed; gobject_class->finalize = xfwm_settings_finalize; @@ -310,9 +269,9 @@ static void -xfwm_settings_init (XfwmSettings *settings, gpointer data) +xfwm_settings_init (XfwmSettings *settings) { - settings->priv = XFWM_SETTINGS_GET_PRIVATE (settings); + settings->priv = xfwm_settings_get_instance_private (settings); settings->priv->builder = NULL; settings->priv->provider = xfce_shortcuts_provider_new ("xfwm4"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.3/src/client.c new/xfwm4-4.14.4/src/client.c --- old/xfwm4-4.14.3/src/client.c 2020-07-25 19:32:38.000000000 +0200 +++ new/xfwm4-4.14.4/src/client.c 2020-08-01 16:18:43.000000000 +0200 @@ -1589,7 +1589,6 @@ gboolean shaped; gchar *wm_name; unsigned long valuemask; - long pid; int i; g_return_val_if_fail (w != None, NULL); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.3/src/hints.c new/xfwm4-4.14.4/src/hints.c --- old/xfwm4-4.14.3/src/hints.c 2020-07-25 18:56:50.000000000 +0200 +++ new/xfwm4-4.14.4/src/hints.c 2020-08-01 15:29:03.000000000 +0200 @@ -1450,7 +1450,7 @@ GPid getWindowPID (DisplayInfo *display_info, Window w) { - GPid pid = 0; + long pid = 0; #ifdef HAVE_XRES XResClientIdSpec client_specs; XResClientIdValue *client_ids = NULL; @@ -1476,7 +1476,7 @@ if (client_ids[i].spec.mask == XRES_CLIENT_ID_PID_MASK) { CARD32 *value = client_ids[i].value; - pid = (GPid) *value; + pid = (long) *value; break; } } @@ -1485,7 +1485,7 @@ if (pid > 0) { - return pid; + return (GPid) pid; } } } @@ -1493,5 +1493,5 @@ getHint (display_info, w, NET_WM_PID, (long *) &pid); - return pid; + return (GPid) pid; }
