Hello community, here is the log from the commit of package lollypop for openSUSE:Factory checked in at 2020-10-23 12:22:38 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/lollypop (Old) and /work/SRC/openSUSE:Factory/.lollypop.new.3463 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "lollypop" Fri Oct 23 12:22:38 2020 rev:137 rq:843479 version:1.4.3 Changes: -------- --- /work/SRC/openSUSE:Factory/lollypop/lollypop.changes 2020-10-10 19:04:56.344501776 +0200 +++ /work/SRC/openSUSE:Factory/.lollypop.new.3463/lollypop.changes 2020-10-23 12:24:07.112782637 +0200 @@ -1,0 +2,6 @@ +Thu Oct 22 17:18:33 UTC 2020 - [email protected] + +- Update to version 1.4.3: + * Bug fixes. + +------------------------------------------------------------------- Old: ---- lollypop-1.4.2.tar.xz New: ---- lollypop-1.4.3.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lollypop.spec ++++++ --- /var/tmp/diff_new_pack.staXbZ/_old 2020-10-23 12:24:09.024788120 +0200 +++ /var/tmp/diff_new_pack.staXbZ/_new 2020-10-23 12:24:09.028788132 +0200 @@ -17,7 +17,7 @@ Name: lollypop -Version: 1.4.2 +Version: 1.4.3 Release: 0 Summary: GNOME music playing application License: GPL-3.0-or-later ++++++ _service ++++++ --- /var/tmp/diff_new_pack.staXbZ/_old 2020-10-23 12:24:09.060788223 +0200 +++ /var/tmp/diff_new_pack.staXbZ/_new 2020-10-23 12:24:09.060788223 +0200 @@ -1,7 +1,7 @@ <services> <service mode="disabled" name="tar_scm"> <param name="changesgenerate">enable</param> - <param name="revision">1.4.2</param> + <param name="revision">1.4.3</param> <param name="scm">git</param> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> <param name="versionformat">@PARENT_TAG@</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.staXbZ/_old 2020-10-23 12:24:09.084788292 +0200 +++ /var/tmp/diff_new_pack.staXbZ/_new 2020-10-23 12:24:09.084788292 +0200 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> - <param name="changesrevision">eac36db4a2b97d553461c1a5d48fda70cda5e6d8</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">e1d2d1f95fa0993acd045b53dd22f73d0fa61497</param></service></servicedata> \ No newline at end of file ++++++ lollypop-1.4.2.tar.xz -> lollypop-1.4.3.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.2/data/org.gnome.Lollypop.appdata.xml.in new/lollypop-1.4.3/data/org.gnome.Lollypop.appdata.xml.in --- old/lollypop-1.4.2/data/org.gnome.Lollypop.appdata.xml.in 2020-10-09 21:46:30.000000000 +0200 +++ new/lollypop-1.4.3/data/org.gnome.Lollypop.appdata.xml.in 2020-10-22 13:45:07.000000000 +0200 @@ -17,7 +17,7 @@ </ul> </description> <releases> - <release version="1.4.2" date="2020-10-09"> + <release version="1.4.3" date="2020-10-22"> <description> </description> </release> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.2/lollypop/application.py new/lollypop-1.4.3/lollypop/application.py --- old/lollypop-1.4.2/lollypop/application.py 2020-10-09 21:46:30.000000000 +0200 +++ new/lollypop-1.4.3/lollypop/application.py 2020-10-22 13:45:07.000000000 +0200 @@ -12,6 +12,7 @@ import gi gi.require_version("Gst", "1.0") +gi.require_version("Gtk", "3.0") gi.require_version("GstAudio", "1.0") gi.require_version("GstPbutils", "1.0") gi.require_version("TotemPlParser", "1.0") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.2/lollypop/database_tracks.py new/lollypop-1.4.3/lollypop/database_tracks.py --- old/lollypop-1.4.2/lollypop/database_tracks.py 2020-10-09 21:46:30.000000000 +0200 +++ new/lollypop-1.4.3/lollypop/database_tracks.py 2020-10-22 13:45:07.000000000 +0200 @@ -634,8 +634,7 @@ request += make_subrequest("album_artists.artist_id=?", "OR", len(artist_ids)) - request += "GROUP BY artists.rowid, tracks.album_id\ - ORDER BY artists.name" + request += "ORDER BY artists.name" result = sql.execute(request, filters) return list(itertools.chain(*result)) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.2/lollypop/helper_passwords.py new/lollypop-1.4.3/lollypop/helper_passwords.py --- old/lollypop-1.4.2/lollypop/helper_passwords.py 2020-10-09 21:46:30.000000000 +0200 +++ new/lollypop-1.4.3/lollypop/helper_passwords.py 2020-10-22 13:45:07.000000000 +0200 @@ -47,7 +47,8 @@ Secret.SchemaFlags.NONE, SecretSchema) items = secret.search_sync(schema, SecretAttributes, - Secret.SearchFlags.ALL, + Secret.SearchFlags.UNLOCK | + Secret.SearchFlags.LOAD_SECRETS, None) if items: items[0].load_secret_sync(None) @@ -77,14 +78,15 @@ Secret.SchemaFlags.NONE, SecretSchema) self.__secret.search(schema, SecretAttributes, - Secret.SearchFlags.ALL, + Secret.SearchFlags.UNLOCK | + Secret.SearchFlags.LOAD_SECRETS, None, self.__on_secret_search, service, callback, *args) except Exception as e: - Logger.error("PasswordsHelper::get(): %s" % e) + Logger.warning("PasswordsHelper::get(): %s" % e) def store(self, service, login, password, callback=None, *args): """ @@ -121,7 +123,7 @@ callback, *args) except Exception as e: - Logger.error("PasswordsHelper::store(): %s" % e) + Logger.warning("PasswordsHelper::store(): %s" % e) def clear(self, service, callback=None, *args): """ @@ -142,13 +144,14 @@ SecretSchema) self.__secret.search(schema, SecretAttributes, - Secret.SearchFlags.ALL, + Secret.SearchFlags.UNLOCK | + Secret.SearchFlags.LOAD_SECRETS, None, self.__on_clear_search, callback, *args) except Exception as e: - Logger.error("PasswordsHelper::clear(): %s" % e) + Logger.warning("PasswordsHelper::clear(): %s" % e) ####################### # PRIVATE # @@ -183,27 +186,6 @@ except Exception as e: Logger.error("PasswordsHelper::__on_clear_search(): %s" % e) - def __on_load_secret(self, source, result, service, callback, *args): - """ - Set userservice/password input - @param source as GObject.Object - @param result as Gio.AsyncResult - @param service as str - @param index as int - @param count as int - @param callback as function - @param args - """ - secret = source.get_secret() - if secret is not None: - callback(source.get_attributes(), - secret.get().decode('utf-8'), - service, - *args) - else: - Logger.error("PasswordsHelper: no secret!") - callback(None, None, service, *args) - def __on_secret_search(self, source, result, service, callback, *args): """ Set userservice/password input @@ -217,14 +199,13 @@ if result is not None: items = source.search_finish(result) for item in items: - item.load_secret(None, - self.__on_load_secret, - service, - callback, - *args) - if not items: - Logger.info("PasswordsHelper: no items!") - callback(None, None, service, *args) + attributes = item.get_attributes() + secret = item.get_secret() + callback(attributes, + secret.get().decode('utf-8'), + service, + *args) + break else: Logger.info("PasswordsHelper: no result!") callback(None, None, service, *args) @@ -240,7 +221,6 @@ """ try: self.__secret = source.get_finish(result) - self.__secret.unlock(self.__secret.get_collections()) except Exception as e: self.__secret = -1 Logger.error("PasswordsHelper::__on_get_secret(): %s" % e) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.2/lollypop/tag_frame_lang.py new/lollypop-1.4.3/lollypop/tag_frame_lang.py --- old/lollypop-1.4.2/lollypop/tag_frame_lang.py 2020-10-09 21:46:30.000000000 +0200 +++ new/lollypop-1.4.3/lollypop/tag_frame_lang.py 2020-10-22 13:45:07.000000000 +0200 @@ -13,6 +13,7 @@ from lollypop.logger import Logger from lollypop.utils_file import decodeUnicode, splitUnicode from lollypop.tag_frame import FrameTag +from lollypop.define import UTF_16_ENCODING, UTF_16BE_ENCODING class FrameLangTag(FrameTag): @@ -34,8 +35,13 @@ @return str/None """ try: - (d, t) = splitUnicode(self.frame[4:], self.encoding) - return decodeUnicode(t, self.encoding) + (d, t) = splitUnicode(self.frame, self.encoding) + if self.encoding in [UTF_16_ENCODING, UTF_16BE_ENCODING]: + (start, end) = t.split(b"\x00\x00\xff", 1) + end = b"\xff" + end + else: + (start, end) = t.split(b"\x00", 1) + return decodeUnicode(end, self.encoding) except Exception as e: Logger.error("FrameLangTag::string: %s, %s", e, self.frame) return "" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.2/lollypop/utils_file.py new/lollypop-1.4.3/lollypop/utils_file.py --- old/lollypop-1.4.2/lollypop/utils_file.py 2020-10-09 21:46:30.000000000 +0200 +++ new/lollypop-1.4.3/lollypop/utils_file.py 2020-10-22 13:45:07.000000000 +0200 @@ -204,13 +204,8 @@ def splitUnicode(data, encoding): - from lollypop.define import UTF_16_ENCODING, UTF_16BE_ENCODING try: (d, t) = data.split(encoding, 1) - # Fix invalid UTF16 - if encoding == UTF_16_ENCODING or encoding == UTF_16BE_ENCODING: - if len(t) % 2 != 0: - t = t[1:] except ValueError as e: Logger.warning("splitUnicode(): %s", e) (d, t) = data, b"" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.2/lollypop/view_information.py new/lollypop-1.4.3/lollypop/view_information.py --- old/lollypop-1.4.2/lollypop/view_information.py 2020-10-09 21:46:30.000000000 +0200 +++ new/lollypop-1.4.3/lollypop/view_information.py 2020-10-22 13:45:07.000000000 +0200 @@ -104,7 +104,8 @@ self.__banner.show() self.__banner.connect("search", self.__on_banner_search) self.__albums_view = AlbumsListView([], [], - ViewType.SCROLLED) + ViewType.SCROLLED | + ViewType.ARTIST) self.__albums_view.set_size_request(350, -1) self.__albums_view.show() self.__albums_view.set_halign(Gtk.Align.END) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.2/meson.build new/lollypop-1.4.3/meson.build --- old/lollypop-1.4.2/meson.build 2020-10-09 21:46:30.000000000 +0200 +++ new/lollypop-1.4.3/meson.build 2020-10-22 13:45:07.000000000 +0200 @@ -1,5 +1,5 @@ project('lollypop', - version: '1.4.2', + version: '1.4.3', meson_version: '>= 0.46.0' ) revision = run_command('bin/revision.sh').stdout().strip()
