Hello community,
here is the log from the commit of package lollypop for openSUSE:Factory
checked in at 2020-10-24 15:18:42
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/lollypop (Old)
and /work/SRC/openSUSE:Factory/.lollypop.new.3463 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "lollypop"
Sat Oct 24 15:18:42 2020 rev:138 rq:843763 version:1.4.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/lollypop/lollypop.changes 2020-10-23
12:24:07.112782637 +0200
+++ /work/SRC/openSUSE:Factory/.lollypop.new.3463/lollypop.changes
2020-10-24 15:19:08.468329852 +0200
@@ -1,0 +2,9 @@
+Sat Oct 24 11:00:58 UTC 2020 - antoine.belv...@opensuse.org
+
+- Update to version 1.4.4:
+ * Fix an issue with equalizer (glgo#World/lollypop#2588).
+ * Use relative path in .m3u files if possible
+ (glgo#World/lollypop#2585).
+ * Fix duration for Last.FM searches.
+
+-------------------------------------------------------------------
Old:
----
lollypop-1.4.3.tar.xz
New:
----
lollypop-1.4.4.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ lollypop.spec ++++++
--- /var/tmp/diff_new_pack.CaFlvr/_old 2020-10-24 15:19:09.008330472 +0200
+++ /var/tmp/diff_new_pack.CaFlvr/_new 2020-10-24 15:19:09.008330472 +0200
@@ -17,7 +17,7 @@
Name: lollypop
-Version: 1.4.3
+Version: 1.4.4
Release: 0
Summary: GNOME music playing application
License: GPL-3.0-or-later
++++++ _service ++++++
--- /var/tmp/diff_new_pack.CaFlvr/_old 2020-10-24 15:19:09.040330509 +0200
+++ /var/tmp/diff_new_pack.CaFlvr/_new 2020-10-24 15:19:09.044330514 +0200
@@ -1,7 +1,7 @@
<services>
<service mode="disabled" name="tar_scm">
<param name="changesgenerate">enable</param>
- <param name="revision">1.4.3</param>
+ <param name="revision">1.4.4</param>
<param name="scm">git</param>
<param name="url">https://gitlab.gnome.org/World/lollypop.git</param>
<param name="versionformat">@PARENT_TAG@</param>
++++++ _servicedata ++++++
--- /var/tmp/diff_new_pack.CaFlvr/_old 2020-10-24 15:19:09.060330532 +0200
+++ /var/tmp/diff_new_pack.CaFlvr/_new 2020-10-24 15:19:09.064330537 +0200
@@ -1,4 +1,4 @@
<servicedata>
<service name="tar_scm">
<param
name="url">https://gitlab.gnome.org/World/lollypop.git</param>
- <param
name="changesrevision">e1d2d1f95fa0993acd045b53dd22f73d0fa61497</param></service></servicedata>
\ No newline at end of file
+ <param
name="changesrevision">91d0384e4547b21e48e7f36d5bcdd0c8d933d5ad</param></service></servicedata>
\ No newline at end of file
++++++ lollypop-1.4.3.tar.xz -> lollypop-1.4.4.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/lollypop-1.4.3/data/org.gnome.Lollypop.appdata.xml.in
new/lollypop-1.4.4/data/org.gnome.Lollypop.appdata.xml.in
--- old/lollypop-1.4.3/data/org.gnome.Lollypop.appdata.xml.in 2020-10-22
13:45:07.000000000 +0200
+++ new/lollypop-1.4.4/data/org.gnome.Lollypop.appdata.xml.in 2020-10-23
22:36:20.000000000 +0200
@@ -17,7 +17,7 @@
</ul>
</description>
<releases>
- <release version="1.4.3" date="2020-10-22">
+ <release version="1.4.4" date="2020-10-23">
<description>
</description>
</release>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lollypop-1.4.3/lollypop/helper_web_lastfm.py
new/lollypop-1.4.4/lollypop/helper_web_lastfm.py
--- old/lollypop-1.4.3/lollypop/helper_web_lastfm.py 2020-10-22
13:45:07.000000000 +0200
+++ new/lollypop-1.4.4/lollypop/helper_web_lastfm.py 2020-10-23
22:36:20.000000000 +0200
@@ -178,7 +178,7 @@
lollypop_payload["artists"] = payload["artist"]["name"]
lollypop_payload["discnumber"] = "1"
lollypop_payload["tracknumber"] = tracknumber
- lollypop_payload["duration"] = payload["duration"]
+ lollypop_payload["duration"] = int(payload["duration"]) * 1000
return lollypop_payload
#######################
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lollypop-1.4.3/lollypop/player_plugins.py
new/lollypop-1.4.4/lollypop/player_plugins.py
--- old/lollypop-1.4.3/lollypop/player_plugins.py 2020-10-22
13:45:07.000000000 +0200
+++ new/lollypop-1.4.4/lollypop/player_plugins.py 2020-10-23
22:36:20.000000000 +0200
@@ -72,7 +72,26 @@
if App().settings.get_value("equalizer-enabled"):
self.__equalizer = Gst.ElementFactory.make("equalizer-nbands",
None)
- self.__equalizer.set_property("num-bands", 18)
+# GStreamer's GstIirEqualizerNBands sets up shelve filters for the first and
+# last bands as corner cases. That was causing the "inverted slider" bug.
+# As a workaround, we create two dummy bands at both ends of the spectrum.
+# This causes the actual first and last adjustable bands to be
+# implemented using band-pass filters.
+# Comment from Clementine source code, thanks Clementine devs!
+ self.__equalizer.set_property("num-bands", 18 + 2)
+ for idx in [0, 19]:
+ band = self.__equalizer.get_child_by_index(idx)
+ band.set_property("freq", 0)
+ band.set_property("bandwidth", 0)
+ band.set_property("gain", 0)
+ # Setup bandwidth, thanks again to Clementine project
+ last_band_freq = 0
+ for idx in range(1, 19):
+ band = self.__equalizer.get_child_by_index(idx)
+ freq = self.__EQUALIZER[idx - 1]
+ bandwidth = freq - last_band_freq
+ last_band_freq = freq
+ band.set_property("bandwidth", bandwidth)
audiobin.add(self.__equalizer)
if replay_gain:
audioconvert_rg.link(self.__equalizer)
@@ -119,7 +138,7 @@
"""
try:
if self.__equalizer is not None:
- band = self.__equalizer.get_child_by_index(index)
+ band = self.__equalizer.get_child_by_index(index + 1)
band.set_property("freq", self.__EQUALIZER[index])
band.set_property("gain", value)
except Exception as e:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lollypop-1.4.3/lollypop/playlists.py
new/lollypop-1.4.4/lollypop/playlists.py
--- old/lollypop-1.4.3/lollypop/playlists.py 2020-10-22 13:45:07.000000000
+0200
+++ new/lollypop-1.4.4/lollypop/playlists.py 2020-10-23 22:36:20.000000000
+0200
@@ -586,10 +586,10 @@
name = self.get_name(playlist_id)
# Clear cache
App().art.remove_artwork_from_cache("playlist_" + name, "ROUNDED")
- uri = self.get_sync_uri(playlist_id)
- if uri is None:
+ playlist_uri = self.get_sync_uri(playlist_id)
+ if playlist_uri is None:
return
- f = Gio.File.new_for_uri(uri)
+ f = Gio.File.new_for_uri(playlist_uri)
if not f.query_exists() and not create:
return
uris = self.get_track_uris(playlist_id)
@@ -598,8 +598,13 @@
stream = f.replace(None, False,
Gio.FileCreateFlags.REPLACE_DESTINATION, None)
stream.write("#EXTM3U\n".encode("utf-8"))
+ playlist_dir_uri = playlist_uri.replace(f.get_basename(), "")
for uri in uris:
- string = "%s\n" % uri
+ if playlist_dir_uri in uri:
+ filepath = uri.replace(playlist_dir_uri, "")
+ string = "%s\n" % GLib.uri_unescape_string(filepath, None)
+ else:
+ string = "%s\n" % uri
stream.write(string.encode("utf-8"))
stream.close()
except Exception as e:
@@ -635,9 +640,10 @@
# Create playlist and get id
basename = ".".join(f.get_basename().split(".")[:-1])
playlist_id = self.get_id(basename)
- if playlist_id is None:
- playlist_id = self.add(basename)
-
+ # Do not reimport playlists
+ if playlist_id is not None:
+ return
+ playlist_id = self.add(basename)
# Check mtime has been updated
with SqlCursor(self) as sql:
result = sql.execute("SELECT mtime\
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lollypop-1.4.3/meson.build
new/lollypop-1.4.4/meson.build
--- old/lollypop-1.4.3/meson.build 2020-10-22 13:45:07.000000000 +0200
+++ new/lollypop-1.4.4/meson.build 2020-10-23 22:36:20.000000000 +0200
@@ -1,5 +1,5 @@
project('lollypop',
- version: '1.4.3',
+ version: '1.4.4',
meson_version: '>= 0.46.0'
)
revision = run_command('bin/revision.sh').stdout().strip()
