Hello community,
here is the log from the commit of package yast2-kdump for openSUSE:Factory
checked in at 2016-07-28 23:42:22
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-kdump (Old)
and /work/SRC/openSUSE:Factory/.yast2-kdump.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-kdump"
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-kdump/yast2-kdump.changes 2016-07-07
15:09:52.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-kdump.new/yast2-kdump.changes
2016-07-28 23:42:23.000000000 +0200
@@ -1,0 +2,6 @@
+Wed Jul 20 13:48:18 CEST 2016 - loci...@suse.com
+
+- Proposing kdump to be disabled by default on ARM64 (bsc#989321)
+- 3.1.39
+
+-------------------------------------------------------------------
Old:
----
yast2-kdump-3.1.38.tar.bz2
New:
----
yast2-kdump-3.1.39.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-kdump.spec ++++++
--- /var/tmp/diff_new_pack.gPwfSg/_old 2016-07-28 23:42:24.000000000 +0200
+++ /var/tmp/diff_new_pack.gPwfSg/_new 2016-07-28 23:42:24.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-kdump
-Version: 3.1.38
+Version: 3.1.39
Release: 0
Summary: Configuration of kdump
License: GPL-2.0
++++++ yast2-kdump-3.1.38.tar.bz2 -> yast2-kdump-3.1.39.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.1.38/package/yast2-kdump.changes
new/yast2-kdump-3.1.39/package/yast2-kdump.changes
--- old/yast2-kdump-3.1.38/package/yast2-kdump.changes 2016-06-29
11:29:09.000000000 +0200
+++ new/yast2-kdump-3.1.39/package/yast2-kdump.changes 2016-07-20
14:01:43.000000000 +0200
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Wed Jul 20 13:48:18 CEST 2016 - loci...@suse.com
+
+- Proposing kdump to be disabled by default on ARM64 (bsc#989321)
+- 3.1.39
+
+-------------------------------------------------------------------
Mon Jun 27 13:23:28 UTC 2016 - jreidin...@suse.com
- Skip writing bootloader configuration in installation, as it
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.1.38/package/yast2-kdump.spec
new/yast2-kdump-3.1.39/package/yast2-kdump.spec
--- old/yast2-kdump-3.1.38/package/yast2-kdump.spec 2016-06-29
11:29:09.000000000 +0200
+++ new/yast2-kdump-3.1.39/package/yast2-kdump.spec 2016-07-20
14:01:43.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-kdump
-Version: 3.1.38
+Version: 3.1.39
Release: 0
Summary: Configuration of kdump
License: GPL-2.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.1.38/src/modules/Kdump.rb
new/yast2-kdump-3.1.39/src/modules/Kdump.rb
--- old/yast2-kdump-3.1.38/src/modules/Kdump.rb 2016-06-29 11:29:09.000000000
+0200
+++ new/yast2-kdump-3.1.39/src/modules/Kdump.rb 2016-07-20 14:01:43.000000000
+0200
@@ -661,9 +661,18 @@
@kdump_packages.concat KDUMP_PACKAGES
end
+ # Proposes default state of kdump (enabled/disabled)
+ #
+ # @return [Boolean] the default proposed state
+
def ProposeCrashkernelParam
- # propose disable kdump if PC has less than 1024MB RAM
+ # proposing disabled kdump if PC has less than 1024MB RAM
if total_memory < 1024
+ log.info "not enough memory - kdump proposed as disabled"
+ false
+ # proposing disabled kdump on aarch64 (bsc#989321) - kdump not
implemented
+ elsif Arch.aarch64
+ log.info "aarch64 - kdump proposed as disabled"
false
else
true
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.1.38/test/kdump_test.rb
new/yast2-kdump-3.1.39/test/kdump_test.rb
--- old/yast2-kdump-3.1.38/test/kdump_test.rb 2016-06-29 11:29:09.000000000
+0200
+++ new/yast2-kdump-3.1.39/test/kdump_test.rb 2016-07-20 14:01:43.000000000
+0200
@@ -46,6 +46,35 @@
end
end
+ describe "#ProposeCrashkernelParam" do
+ before do
+ allow(Yast::Kdump).to receive(:total_memory).and_return 1024
+ allow(Yast::Arch).to receive(:aarch64).and_return false
+ end
+
+ context "while running on machine with less than 1024 MB memory" do
+ it "proposes kdump to be disabled" do
+ allow(Yast::Kdump).to receive(:total_memory).and_return 1023
+
+ expect(Yast::Kdump.ProposeCrashkernelParam).to eq false
+ end
+ end
+
+ context "while running on ARM64" do
+ it "proposes kdump to be disabled" do
+ allow(Yast::Arch).to receive(:aarch64).and_return true
+
+ expect(Yast::Kdump.ProposeCrashkernelParam).to eq false
+ end
+ end
+
+ context "otherwise" do
+ it "always proposes kdump to be enabled" do
+ expect(Yast::Kdump.ProposeCrashkernelParam).to eq true
+ end
+ end
+ end
+
let(:partition_info) do
[
{ "free" => 389318, "name" => "/", "used" => 1487222 },
