Hello community,
here is the log from the commit of package yast2-installation for
openSUSE:Factory checked in at 2016-09-24 15:18:35
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-installation (Old)
and /work/SRC/openSUSE:Factory/.yast2-installation.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-installation"
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-installation/yast2-installation.changes
2016-09-17 14:35:56.000000000 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-installation.new/yast2-installation.changes
2016-09-24 15:18:37.000000000 +0200
@@ -1,0 +2,8 @@
+Wed Sep 21 11:00:27 CEST 2016 - sch...@suse.de
+
+- Fixed crash if one defined proposal module has not been found on
+ system while switching back from "Expert" proposal.
+ (bnc#999953)
+- 3.1.217
+
+-------------------------------------------------------------------
@@ -4,0 +13 @@
+- 3.1.216
Old:
----
yast2-installation-3.1.215.tar.bz2
New:
----
yast2-installation-3.1.217.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-installation.spec ++++++
--- /var/tmp/diff_new_pack.cHtWkJ/_old 2016-09-24 15:18:38.000000000 +0200
+++ /var/tmp/diff_new_pack.cHtWkJ/_new 2016-09-24 15:18:38.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-installation
-Version: 3.1.215
+Version: 3.1.217
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-installation-3.1.215.tar.bz2 -> yast2-installation-3.1.217.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.215/package/yast2-installation.changes
new/yast2-installation-3.1.217/package/yast2-installation.changes
--- old/yast2-installation-3.1.215/package/yast2-installation.changes
2016-09-15 13:38:11.000000000 +0200
+++ new/yast2-installation-3.1.217/package/yast2-installation.changes
2016-09-21 13:12:59.000000000 +0200
@@ -1,7 +1,16 @@
-------------------------------------------------------------------
+Wed Sep 21 11:00:27 CEST 2016 - sch...@suse.de
+
+- Fixed crash if one defined proposal module has not been found on
+ system while switching back from "Expert" proposal.
+ (bnc#999953)
+- 3.1.217
+
+-------------------------------------------------------------------
Wed Sep 14 13:53:41 UTC 2016 - jreidin...@suse.com
- reduce time needed for building this package
+- 3.1.216
-------------------------------------------------------------------
Tue Sep 13 12:37:57 UTC 2016 - jreidin...@suse.com
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.215/package/yast2-installation.spec
new/yast2-installation-3.1.217/package/yast2-installation.spec
--- old/yast2-installation-3.1.215/package/yast2-installation.spec
2016-09-15 13:38:11.000000000 +0200
+++ new/yast2-installation-3.1.217/package/yast2-installation.spec
2016-09-21 13:12:59.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-installation
-Version: 3.1.215
+Version: 3.1.217
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.215/src/lib/installation/proposal_store.rb
new/yast2-installation-3.1.217/src/lib/installation/proposal_store.rb
--- old/yast2-installation-3.1.215/src/lib/installation/proposal_store.rb
2016-09-15 13:38:11.000000000 +0200
+++ new/yast2-installation-3.1.217/src/lib/installation/proposal_store.rb
2016-09-21 13:12:59.000000000 +0200
@@ -531,7 +531,7 @@
modules_order.each_with_object("") do |client, text|
description = description_for(client)
- text << description["help"] if description["help"]
+ text << description["help"] if description && description["help"]
end
else
""
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.215/test/proposal_store_test.rb
new/yast2-installation-3.1.217/test/proposal_store_test.rb
--- old/yast2-installation-3.1.215/test/proposal_store_test.rb 2016-09-15
13:38:11.000000000 +0200
+++ new/yast2-installation-3.1.217/test/proposal_store_test.rb 2016-09-21
13:13:00.000000000 +0200
@@ -90,6 +90,15 @@
it "returns string with localized help" do
expect(subject.help_text).to be_a String
end
+
+ it "does not crash if modules have not been found" do
+ # bnc#999953
+ allow(subject).to receive(:presentation_order)
+ .and_return([["test1", "test2", "test3"]])
+ allow(subject).to receive(:tabs?).and_return(true)
+
+ expect(subject.help_text(0)).to be_a String
+ end
end
describe "#proposal_names" do
