[OS-webwork] XWork source

[Rickard Öberg]

Patrick,

I'm looking through the new XWork code and I'm getting really scared. There's a LOT of stuff happening each time an action is invoked. Lots of methods are called, lots of objects are created (and then discarded) and a lot of copying, converting etc. is going on. Just the stuff created by GenericDispatcher is during one single execution is scary. I doubt this will scale at all I'm afraid. :-(

Also, the XML is VERY verbose. Can you explain why the XML declares action and result parameters? It seems as though you're using XML to do configuration of individual actions. Since they're not reused this configuration will have to be re-initialized for each invocation which is going to be bad performance-wise. Also, why do you have <result><result-params><param> instead of just <result><param>?

So far the code gets a thumbs down. It needs to be MUCH leaner and meaner.

/Rickard

--
Rickard Öberg
[EMAIL PROTECTED]
Senselogic

Got blog? I do. http://dreambean.com



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork