OK, sure, let's talk about it it more (or maybe I'll piggyback on to the massive "rethink" thread!).
The XML config is verbose, and it could be cleaned up a bit. It was a first attempt to just show the features of the underlying Configuration interface. I don't expect it to last at all in it's current form. As for objects being created, I haven't run a profiler or anything like that. Can you give me some more detail of what you're seeing that is "bad" and what you're seeing that is "very bad"? :) -Pat ----- Original Message ----- From: "Rickard Öberg" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, December 30, 2002 1:10 AM Subject: [OS-webwork] XWork source > Patrick, > > I'm looking through the new XWork code and I'm getting really scared. > There's a LOT of stuff happening each time an action is invoked. Lots of > methods are called, lots of objects are created (and then discarded) and > a lot of copying, converting etc. is going on. Just the stuff created by > GenericDispatcher is during one single execution is scary. I doubt this > will scale at all I'm afraid. :-( > > Also, the XML is VERY verbose. Can you explain why the XML declares > action and result parameters? It seems as though you're using XML to do > configuration of individual actions. Since they're not reused this > configuration will have to be re-initialized for each invocation which > is going to be bad performance-wise. Also, why do you have > <result><result-params><param> instead of just <result><param>? > > So far the code gets a thumbs down. It needs to be MUCH leaner and meaner. > > /Rickard > > -- > Rickard Öberg > [EMAIL PROTECTED] > Senselogic > > Got blog? I do. http://dreambean.com > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
