Hi,
I just noticed that some developer (I believe the CVS name was "salaman")
had made changes to all the property editors after the 1.3RC1.
Those changes were now overwritten when Patrick submitted my contributions
for the new thread safe editors.
The changes made by "salaman" was that in the setAsText method there was an
added check for null values or empty strings. In that case the value was set
to null instead of throwing an IllegalArgumentException. Like this:
public void setAsText(String txt) {
if (txt==null || txt.equals(""))
{
setValue(null);
return;
}
try {
...
This is a perfectly reasonable change (I use similar code in my own property
editors), but it is not completely backwards compatible, since no
IllegalArgumentException will be thrown for null values anymore. It should
not be used for primitive types of course.
So the question is: should this be re-implemented for the new 1.3 release? I
would say no, because of backwards compatibility problems.
Opinions anyone? Salaman?
Cheers,
Dick
[EMAIL PROTECTED]
-------------------------------------------------------
This SF.NET email is sponsored by: Thawte.com
Understand how to protect your customers personal information by implementing
SSL on your Apache Web Server. Click here to get our FREE Thawte Apache
Guide: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0029en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
