Odd that Victor Salaman was the last one to have changed those, he hasn't
worked on WebWork in _ages_. I think setting to null would be a good idea,
the errors reported back by the PropertyEditors were pretty lame anyway
("Could not set value for").
-Pat
----- Original Message -----
From: "Dick Zetterberg" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, January 17, 2003 2:55 AM
Subject: [OS-webwork] webwork.util.editor handling of null
> Hi,
>
> I just noticed that some developer (I believe the CVS name was "salaman")
> had made changes to all the property editors after the 1.3RC1.
> Those changes were now overwritten when Patrick submitted my contributions
> for the new thread safe editors.
>
> The changes made by "salaman" was that in the setAsText method there was
an
> added check for null values or empty strings. In that case the value was
set
> to null instead of throwing an IllegalArgumentException. Like this:
>
> public void setAsText(String txt) {
> if (txt==null || txt.equals(""))
> {
> setValue(null);
> return;
> }
> try {
> ...
>
> This is a perfectly reasonable change (I use similar code in my own
property
> editors), but it is not completely backwards compatible, since no
> IllegalArgumentException will be thrown for null values anymore. It should
> not be used for primitive types of course.
> So the question is: should this be re-implemented for the new 1.3 release?
I
> would say no, because of backwards compatibility problems.
> Opinions anyone? Salaman?
>
> Cheers,
>
> Dick
>
> [EMAIL PROTECTED]
>
>
>
> -------------------------------------------------------
> This SF.NET email is sponsored by: Thawte.com
> Understand how to protect your customers personal information by
implementing
> SSL on your Apache Web Server. Click here to get our FREE Thawte Apache
> Guide: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0029en
> _______________________________________________
> Opensymphony-webwork mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
-------------------------------------------------------
This SF.NET email is sponsored by: Thawte.com - A 128-bit supercerts will
allow you to extend the highest allowed 128 bit encryption to all your
clients even if they use browsers that are limited to 40 bit encryption.
Get a guide here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
