On Thursday 06 March 2008 10:08, Jan-Oliver Wagner wrote: > On Montag, 3. März 2008, Bernhard Herzog wrote: [about improvements to implementation of the nasl function hexstr] > > This makes the code simpler, avoids strcat altogether and should be more > > efficient. The original code has quadratic runtime because the strcat has > > to repeatedly determine the length of ret. > > > > If we change the code in this way, we should add a testcase for > > hexstr to the testsuite, though. > > makes sense to me. I do not expect huge performance wins.
Me neither. It would just be a nice collateral benefit of the simpler implementation. Bernhard -- Bernhard Herzog Intevation GmbH, Osnabrück Amtsgericht Osnabrück, HR B 18998 http://www.intevation.de/ Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
pgp7xlQb6sW3Z.pgp
Description: PGP signature
_______________________________________________ Openvas-devel mailing list [email protected] http://lists.wald.intevation.org/mailman/listinfo/openvas-devel
