Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/677?usp=email )
Change subject: route: copied 'gateway_needed' logic from add_route_ipv6 to add_route ...................................................................... Patch Set 9: (5 comments) Patchset: PS9: Getting there... File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/677/comment/cc58944a_810b6a73 : PS9, Line 1585: #if !defined(TARGET_LINUX) why is that `#ifndef` moved`? It's not used by the new Linux code either, or am I misreading it (so, no -Werror safe)? http://gerrit.openvpn.net/c/openvpn/+/677/comment/fc88af46_52bd13d6 : PS9, Line 1599: this blank line (and the one at the end of the if()) feel superfluous http://gerrit.openvpn.net/c/openvpn/+/677/comment/6c4000d3_493952ff : PS9, Line 1616: if (gateway_needed && r->gateway == 0) if we add this here, we might consider getting rid of this warning in `init_route()` then... but this is a bit complex, as for most platforms `gateway_needed = true` is still valid, due to limits in route table handling http://gerrit.openvpn.net/c/openvpn/+/677/comment/1ea919ca_7a56279c : PS9, Line 1634: #if defined(TARGET_LINUX) this needs to go - two `#if defined(TARGET_LINUX)` next to each other, with nothing else in between. Or am I misreading the diff? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/677?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1 Gerrit-Change-Number: 677 Gerrit-PatchSet: 9 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mrbff <ma...@mandelbit.com> Gerrit-Comment-Date: Thu, 19 Sep 2024 11:10:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
