Attention is currently required from: cron2, flichtenheld, plaisthos. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/677?usp=email )
Change subject: route: copied 'gateway_needed' logic from add_route_ipv6 to add_route ...................................................................... Patch Set 10: (5 comments) File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/677/comment/6cceaa5b_47265977 : PS5, Line 1598: #ifndef _WIN32 > preprocessor directives should not be indented Done File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/677/comment/71e62482_873a6e01 : PS9, Line 1585: #if !defined(TARGET_LINUX) > why is that `#ifndef` moved`? It's not used by the new Linux code either, or > am I misreading it (so […] "network" is now used in the new waning http://gerrit.openvpn.net/c/openvpn/+/677/comment/39ad8e78_7d4d9eb3 : PS9, Line 1599: > this blank line (and the one at the end of the if()) feel superfluous Done http://gerrit.openvpn.net/c/openvpn/+/677/comment/aa38e9c7_74e2196e : PS9, Line 1616: if (gateway_needed && r->gateway == 0) > if we add this here, we might consider getting rid of this warning in > `init_route()` then... […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/677/comment/423f7057_a24ac63a : PS9, Line 1634: #if defined(TARGET_LINUX) > this needs to go - two `#if defined(TARGET_LINUX)` next to each other, with > nothing else in between. […] no, you are right, my bad -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/677?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1 Gerrit-Change-Number: 677 Gerrit-PatchSet: 10 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 19 Sep 2024 12:58:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
