Attention is currently required from: its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )
Change subject: Add support for simultaneous use of UDP and TCP sockets ...................................................................... Patch Set 17: (4 comments) Patchset: PS17: some first comments and questions File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/65aa7624_6dd5ee39 : PS17, Line 2471: spurious new line File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/2164b42d_ffbff47e : PS17, Line 57: if (mi && !proto_is_dgram(ls->info.proto)) why would this be called for an UDP packet in the first place, that is, why is that check necessary? http://gerrit.openvpn.net/c/openvpn/+/764/comment/c70f7c01_8761d3d9 : PS17, Line 156: if (proto_is_dgram(mi->context.c2.link_sockets[0]->info.proto)) same here: why is this check necessary? Who calls a `_tcp_` function for UDP packets, and why? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/764?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31bbf87e4e568021445c7512ecefadfd4a69b363 Gerrit-Change-Number: 764 Gerrit-PatchSet: 17 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 21:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
