Attention is currently required from: cron2, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )
Change subject: Add support for simultaneous use of UDP and TCP sockets ...................................................................... Patch Set 17: (13 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/d2d2bf21_d4657dec : PS17, Line 2471: > spurious new line Done File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/557e83eb_4b361d4d : PS17, Line 3834: > this (and the next) blank line are arguably good, and should be kept, no? Done http://gerrit.openvpn.net/c/openvpn/+/764/comment/e3883fac_7a141a70 : PS17, Line 228: if (ce->proto != PROTO_TCP && c->mode != CM_CHILD_TCP) > what's the reason for this change? the conditions should be the same? Done http://gerrit.openvpn.net/c/openvpn/+/764/comment/098aad10_d6ea2c6c : PS17, Line 616: c->options.ce.proto = proto; > this does not look right. So we advance to the next ce, but keep the proto? > Wouldn't that break […] Done http://gerrit.openvpn.net/c/openvpn/+/764/comment/d2412021_82123c38 : PS17, Line 2687: if (!proto_is_udp(c->c2.link_sockets[0]->info.proto) && c->options.ce.explicit_exit_notification) > this like is getting a bit long, so I think wrapping might be a good thing Done http://gerrit.openvpn.net/c/openvpn/+/764/comment/d9a8ec74_c1f662c7 : PS17, Line 3369: } > given that `link_socket_proto_connection_oriented()` (nowadays) is a very > long form of `if (!proto_i […] Done File src/openvpn/mroute.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/8b5bd492_5d35e8a3 : PS17, Line 424: buf_printf(&out, ":%d", maddr.proto); > we should not unconditionally add this `:%d`. […] Done File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/e4035612_308aec8e : PS17, Line 57: if (mi && !proto_is_dgram(ls->info.proto)) > why would this be called for an UDP packet in the first place, that is, why > is that check necessary? that's a leftover from early development when still trying to untangle udp and tcp clients. http://gerrit.openvpn.net/c/openvpn/+/764/comment/74a66627_6f73d597 : PS17, Line 156: if (proto_is_dgram(mi->context.c2.link_sockets[0]->info.proto)) > same here: why is this check necessary? Who calls a `_tcp_` function for UDP > packets, and why? see answer above File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/f9770527_5f1c061a : PS17, Line 1052: setenv_local_entry(es, o->ce.local_list->array[i], i+1); > you have an i+1 here, and another i+1 inside `setenv_local_entry()`... […] i'm not sure either http://gerrit.openvpn.net/c/openvpn/+/764/comment/bb8e11ad_17fcd75d : PS17, Line 3192: o->ce.proto = ce->proto; > what is `o->ce. […] o->ce differs from let's say o->connection_list->array[0] but this is not a big deal on server side while it can be dangerous on client side so a copy won't hurt. http://gerrit.openvpn.net/c/openvpn/+/764/comment/efef2d42_e743e796 : PS17, Line 3198: if (ce->local_list->array[i]->proto == PROTO_TCP) > So we walk the list here, for the `--server` case, and then walk it again in > `option_postprocess_mut […] Done http://gerrit.openvpn.net/c/openvpn/+/764/comment/809120a8_8e4a8ed5 : PS17, Line 3838: msg(M_INFO, "NOTE: --fast-io is disabled while using multi-socket"); > that comment needs to be something like `--fast-ip is disabled if there is a > TCP socket active` or s […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/764?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31bbf87e4e568021445c7512ecefadfd4a69b363 Gerrit-Change-Number: 764 Gerrit-PatchSet: 17 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Comment-Date: Fri, 31 Jan 2025 10:42:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
