Attention is currently required from: plaisthos, selvanair. cron2 has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1415?usp=email )
Change subject: pull-filter: improve documentation ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File doc/man-sections/client-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1415/comment/733a8042_b2df151c?usp=email : PS1, Line 349: protect against offending options pushed by a server. For example, the I would word the first part slightly differently (just as a suggestion) ``` *Warning:* if using ``pull-filter`` as a security measure to protect against offending options pushed by a server, a negative match (ignore/reject) might be circumvented by pushing options with extra spaces... ``` and then the rest as is - except that I think it needs to be the other way round, first the specific ``accept`` and then the generic ``ignore`` - the logic is "first match decided"... so ``` pull-filter accept route 1.2.3.0 pull-filter ignore route ``` would permit 1.2.3.0, while the other way round would ignore all routes. At least this is what I remember and the code seems to agree with me :-) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1415?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2c8d40038e52fbdff1c56f93db1e6a2f9255c59a Gerrit-Change-Number: 1415 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: selvanair <[email protected]> Gerrit-Comment-Date: Mon, 08 Dec 2025 11:07:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
