Attention is currently required from: plaisthos, selvanair.

cron2 has posted comments on this change by selvanair. ( 
http://gerrit.openvpn.net/c/openvpn/+/1415?usp=email )

Change subject: pull-filter: improve documentation
......................................................................


Patch Set 1:

(1 comment)

File doc/man-sections/client-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1415/comment/9a5b4c11_dfcbcb2d?usp=email :
PS1, Line 349:   protect against offending options pushed by a server. For 
example, the
> This is what I wanted to say: Pull filter was not designed as a security 
> measure, so do not use it f […]
Mmmh.  I do think it's reasonably secure if used correctly (allowlist) *but* I 
agree that one needs to take care and it's easy to produce something that works 
against a non-malicious server that just pushes an unwanted route, and consider 
that "secure".  Which it quite likely won't be.

This is what my suggested wording was intended to convey ;-)

But we can agree to disagree on this - in this case I'd go for "Option 2".



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1415?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2c8d40038e52fbdff1c56f93db1e6a2f9255c59a
Gerrit-Change-Number: 1415
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: selvanair <[email protected]>
Gerrit-Comment-Date: Mon, 08 Dec 2025 17:00:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
Comment-In-Reply-To: selvanair <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to