On 02/19/2010 04:57:30 PM, David Sommerseth wrote:

Am I wrong or does using --disable-depr-random-resolv
not remove the random choice?


> From: David Sommerseth <d...@users.sourceforge.net>

> For now this feature is enabled by default, but can be disabled by
> running
> ./configure with --disable-depr-random-resolv.  In the future this
> will be
> changed to being disabled by default before getting removed.


> diff --git a/socket.c b/socket.c
> index fecc398..c963a21 100644
> --- a/socket.c
> +++ b/socket.c
> @@ -205,6 +205,10 @@ getaddr (unsigned int flags,
>       {
>         if (h->h_addr_list[1]) /* more than one address returned */
>           {
> +#ifdef DEPRECATED_RANDOM_RESOLV
> +#warning
> +#warning **** DEPRECATED FEATURE ****   DEPRECATED_RANDOM_RESOLV is
> enabled
> +#warning
>             int n = 0;
>  
>             /* count address list */
> @@ -212,12 +216,16 @@ getaddr (unsigned int flags,
>               ++n;
>             ASSERT (n >= 2);
>  
> -           msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to
> %d addresses, choosing one by random",
> -                hostname,
> -                n);
> +           msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to
> %d addresses, choosing one by random."
> +                   " [DEPRECATED FEATURE]", hostname, n);
>  
>             /* choose address randomly, for basic load-balancing
> capability */
>             ia.s_addr = *(in_addr_t *) (h->h_addr_list[get_random
> () % n]);
> +
> +#else /* preferred solution */
> +           msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to
> more than one IP address, will "
> +                   "use the first resolved address", hostname);
> +#endif /* ENABLE_RANDOM_RESOLV */
>           }
>       }
>  
> -- 
> 1.6.6
> 
> 
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
> 
> 




Karl <k...@meme.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein


Reply via email to