-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 20/02/10 00:06, Karl O. Pinc wrote: > On 02/19/2010 04:57:30 PM, David Sommerseth wrote: > > Am I wrong or does using --disable-depr-random-resolv > not remove the random choice?
That is correct. According to the newly agreed feature removal process, deprecated features should in the beginning be enabled but give warnings when they are triggered. At some point, this behaviour will be switched to be disabled, and you need to do use --enable-depr-random-resolv. And if nobody complains in the end, this code will be removed completely. See the "Feature deprecatoin" section here for more info: <http://www.secure-computing.net/wiki/index.php/OpenVPN/Developer_documentation> kind regards, David Sommerseth >> From: David Sommerseth <d...@users.sourceforge.net> > >> For now this feature is enabled by default, but can be disabled by >> running >> ./configure with --disable-depr-random-resolv. In the future this >> will be >> changed to being disabled by default before getting removed. > > >> diff --git a/socket.c b/socket.c >> index fecc398..c963a21 100644 >> --- a/socket.c >> +++ b/socket.c >> @@ -205,6 +205,10 @@ getaddr (unsigned int flags, >> { >> if (h->h_addr_list[1]) /* more than one address returned */ >> { >> +#ifdef DEPRECATED_RANDOM_RESOLV >> +#warning >> +#warning **** DEPRECATED FEATURE **** DEPRECATED_RANDOM_RESOLV is >> enabled >> +#warning >> int n = 0; >> >> /* count address list */ >> @@ -212,12 +216,16 @@ getaddr (unsigned int flags, >> ++n; >> ASSERT (n >= 2); >> >> - msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to >> %d addresses, choosing one by random", >> - hostname, >> - n); >> + msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to >> %d addresses, choosing one by random." >> + " [DEPRECATED FEATURE]", hostname, n); >> >> /* choose address randomly, for basic load-balancing >> capability */ >> ia.s_addr = *(in_addr_t *) (h->h_addr_list[get_random >> () % n]); >> + >> +#else /* preferred solution */ >> + msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to >> more than one IP address, will " >> + "use the first resolved address", hostname); >> +#endif /* ENABLE_RANDOM_RESOLV */ >> } >> } >> >> -- >> 1.6.6 >> >> >> ------------------------------------------------------------------------------ >> Download Intel® Parallel Studio Eval >> Try the new software tools for yourself. Speed compiling, find bugs >> proactively, and fine-tune applications for parallel performance. >> See why Intel Parallel Studio got high marks during beta. >> http://p.sf.net/sfu/intel-sw-dev >> _______________________________________________ >> Openvpn-devel mailing list >> Openvpn-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/openvpn-devel >> >> > > > > > Karl <k...@meme.com> > Free Software: "You don't pay back, you pay forward." > -- Robert A. Heinlein > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkt/GqoACgkQDC186MBRfrpghACeMK7u3dl70KFe8lWQvaHw2qa5 qJAAnjD1h9hTJgzdMrS5TYS1ADNn0fHt =JlPD -----END PGP SIGNATURE-----
