David Sommerseth wrote: > > 3) "sizeof(common_name)" is useless... Line 745: char > > common_name[TLS_USERNAME_LEN]; we can use directly TLS_USERNAME_LEN. > > Thanks a lot for the patch and all rework done. (Also: thank you to all > reviewers!) > > The third and last patch looks very good! I've applied it to the > feat_misc branch and merged it into allmerged.
I strongly agree with Alon about sizeof() rather than a second reference to the same define. It is the defensive way. //Peter
