-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 25/06/10 11:20, Emilien Mantel wrote:
> Hi,
>
> See attached a very small patch (based on allmerged tree) to fix "sizeof".
Thanks a lot!
commit 031d18fcb8a2a552aecabb41f1afdfe3f51bdd58
Author: Emilien Mantel <emilien.man...@businessdecision.com>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Sat Jun 26 13:56:48 2010 +0200
Fixed static defined length check to use sizeof()
This comes in addition to commit 935c62be9c0c8a256112d after some
additional review comments.
Signed-off-by: Emilien Mantel <emilien.man...@businessdecision.com>
Acked-by: Peter Stuge <pe...@stuge.se>
Signed-off-by: David Sommerseth <d...@users.sourceforge.net>
Applied to feat_misc and merged into allmerged.
kind regards,
David Sommerseth
> Le 18/06/2010 02:01, Peter Stuge a écrit :
>> David Sommerseth wrote:
>>
>>>> 3) "sizeof(common_name)" is useless... Line 745: char
>>>> common_name[TLS_USERNAME_LEN]; we can use directly TLS_USERNAME_LEN.
>>>>
>>> Thanks a lot for the patch and all rework done. (Also: thank you to all
>>> reviewers!)
>>>
>>> The third and last patch looks very good! I've applied it to the
>>> feat_misc branch and merged it into allmerged.
>>>
>> I strongly agree with Alon about sizeof() rather than a second
>> reference to the same define. It is the defensive way.
>>
>>
>> //Peter
>>
>> ------------------------------------------------------------------------------
>>
>> ThinkGeek and WIRED's GeekDad team up for the Ultimate
>> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
>> lucky parental unit. See the prize list and enter to win:
>> http://p.sf.net/sfu/thinkgeek-promo
>> _______________________________________________
>> Openvpn-devel mailing list
>> Openvpn-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>>
>
>
>
> ------------------------------------------------------------------------------
> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parental unit. See the prize list and enter to win:
> http://p.sf.net/sfu/thinkgeek-promo
>
>
>
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkwl7G4ACgkQDC186MBRfroyaACfVDmQ4OI9lQ5JgcWGWyqeWbVu
Ev4An3kjEVIkII14MtTIcFqAazY+2sFC
=pq/V
-----END PGP SIGNATURE-----
