On Fri, Feb 17, 2012 at 11:51 AM, Heiko Hund <heiko.h...@sophos.com> wrote: > Alon, > > On Thursday 16 February 2012 18:37:21 Alon Bar-Lev wrote: >> On Thu, Feb 16, 2012 at 7:30 PM, Heiko Hund <heiko.h...@sophos.com> wrote: >> > Windows API CommandLineToArgvW(), introduced in Windows unicode path >> > commit 71bbbd76c62630c88441237d72fe5b61f0b45b2a, is defined therein. >> >> Usually this should be avoided and get command-line from wmain(). > > the general idea is to make Unicode things happen without changing the openvpn > code too much in a very Windows specific way. Converting UCS-2 to UTF-8 > directly where input and output is happening and passing it through the rest > of openvpn as char* does that. I don't see any benefit in converting openvpn > into a native unicode binary.
I agree. Compiling entry point as wmain and not main is not bigger change than any other change in the unicode patch. Anyway as it seem we have an opportunity window to cleanup the mess, so apply whatever needed in orderer to make it work and then we revise it. Personally, I don't think this unicode patch was ready to be merged... Alon.
