On Fri, Feb 17, 2012 at 11:39 AM, Heiko Hund <heiko.h...@sophos.com> wrote: > Alon, > > On Thursday 16 February 2012 18:34:34 Alon Bar-Lev wrote: >> Anyway, this is not the correct solution. >> Correct solution is to have config-msvc.h and have: >> --- >> #define mode_t int > > I don't think that a MSVC specific header will do good. mode_t shouldn't > actually be used in mingw either, even if they define it. I stumbled over such > glue code a couple of times and the only reason I can come up with why they > have it is backwards compatibility with old code. So it's rather a general > WIN32 thing. And I absolutely agree that putting all the WIN32 stuff into > win32.[ch] would make the code prettier. I just don't feel enough itch to > approach this scratching myself. >
You will be surprised how mingw is better in this sense. Anyway, as I wrote commit whatever you need for now, we will clean up the build system soon. Alon.
