Big NAK. This X_OK is standard define. It exists in mingw as 1. OpenVPN should not check execute if unsupported by OS, not changing standard constants.
Heiko, Where exactly is the problem? When directories are checked or script? Correct patch would be to have a macro for execute ok in option.c which is declared differently for windows. Alon. On Mon, Feb 20, 2012 at 12:10 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 18/02/12 20:44, Heiko Hund wrote: >> The _access and _waccess functions in Windows don't know about X_OK >> (1). If you pass an uneven mode flag the C runtime's default invalid >> parameter handler ends execution of openvpn. >> >> Signed-off-by: Heiko Hund <heiko.h...@sophos.com> --- win/config.h.in >> | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) >> > > ACK and applied to master branch on -testing and -stable trees. > > commit 4ebc587eab73e03ef64d344a5707d84e7f8d875a > Author: Heiko Hund <heiko.h...@sophos.com> > Date: Sat Feb 18 20:44:12 2012 +0100 > > define access mode flag X_OK as 0 on Windows > > Signed-off-by: Heiko Hund <heiko.h...@sophos.com> > Acked-by: David Sommerseth <dav...@redhat.com> > Signed-off-by: David Sommerseth <dav...@redhat.com> > > > kind regards, > > David Sommerseth > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iEYEARECAAYFAk9CHC8ACgkQDC186MBRfrrHegCfUMxu2lHG4Rso8cw1qt7eLEZN > OgAAn0cAwDCQKUq5MLJd6WAZJeVsdyje > =2vak > -----END PGP SIGNATURE----- > > ------------------------------------------------------------------------------ > Try before you buy = See our experts in action! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-dev2 > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel
